From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Jason Chen <jason.z.chen@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] media: dt-bindings: Add OmniVision OV08X40
Date: Thu, 3 Oct 2024 12:47:09 +0000 [thread overview]
Message-ID: <Zv6STSKeNNlT83ux@kekkonen.localdomain> (raw)
In-Reply-To: <7ab7a7f0-c035-4210-b4d0-9e08291be475@linaro.org>
Hi Bryan,
On Thu, Oct 03, 2024 at 01:40:34PM +0100, Bryan O'Donoghue wrote:
> On 03/10/2024 13:31, Krzysztof Kozlowski wrote:
> > > > Ah I understand you.
> > > >
> > > > You're saying the link-frequencies we have in
> > > > Documentation/devicetree/bindings/media/i2c/* are redundant absent hardware
> > > > specific link frequencies being enumerated.
> > > >
> > > > I'll either enumerate the acceptable set or drop this.
> > > link-frequencies should remain mandatory in bindings, whether there are
> > > hardware specific limits in bindings or not.
> > > <URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-
> > > sensor.html#handling-clocks>
> > Yep and my comment was not under required field. Why all this discussion
> > is taken out of context? No wonder everyone interprets it differently.
> >
> > Best regards,
>
> Just so I'm 100% clear.
>
> required:
> link-frequencies
>
> is required but
>
> properties:
> link-frequencies: true
>
> is not, and presumably should be dropped from other yaml descriptions
> upstream.
Seems good to me.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2024-10-03 12:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 13:58 [PATCH v3 0/4] ov08x40: Enable use of ov08x40 on Qualcomm X1E80100 CRD Bryan O'Donoghue
2024-10-02 13:58 ` [PATCH v3 1/4] media: ov08x40: Fix burst write sequence Bryan O'Donoghue
2024-10-02 13:58 ` [PATCH v3 2/4] media: dt-bindings: Add OmniVision OV08X40 Bryan O'Donoghue
2024-10-03 8:29 ` Krzysztof Kozlowski
2024-10-03 8:33 ` Bryan O'Donoghue
2024-10-03 8:36 ` Krzysztof Kozlowski
2024-10-03 8:38 ` Bryan O'Donoghue
2024-10-03 10:17 ` Krzysztof Kozlowski
2024-10-03 11:54 ` Bryan O'Donoghue
2024-10-03 12:17 ` Sakari Ailus
2024-10-03 12:31 ` Krzysztof Kozlowski
2024-10-03 12:40 ` Bryan O'Donoghue
2024-10-03 12:47 ` Sakari Ailus [this message]
2024-10-03 12:48 ` Bryan O'Donoghue
2024-10-03 12:46 ` Sakari Ailus
2024-10-02 13:58 ` [PATCH v3 3/4] media: ov08x40: Rename ext_clk to xvclk Bryan O'Donoghue
2024-10-02 13:58 ` [PATCH v3 4/4] media: ov08x40: Add OF probe support Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv6STSKeNNlT83ux@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jason.z.chen@intel.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox