Re: [ANN] Media Summit September 16th: Final Agenda (v7)

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Ricardo,

On Thu, Sep 26, 2024 at 12:59:35PM +0200, Ricardo Ribalda wrote:
> Hi
> 
> On Thu, 26 Sept 2024 at 12:54, Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > Hi Ricardo,
> >
> > On Thu, Sep 26, 2024 at 12:46:49PM +0200, Ricardo Ribalda wrote:
> > > > > > I'd argue that even a missing SoB may not be a cause for rebase if it's
> > > > > > an accident, but that's not worth debating because CI will make sure
> > > > > > this never happens.
> > > > >
> > > > > Does it?
> > > > >
> > > > > checkpatch.pl checks should just be warnings. And that should probably
> > > > > stay. Sob: and From: being different isn't necessarily that far-fetched as
> > > > > having an address in .mailmap may change From: field but not Sob:,
> > > > > resulting in a checkpatch.pl warning.
> > > > >
> > > > > I wonder if checkpatch.pl should know about .mailmap actually, currently it
> > > > > doesn't. I could send a patch.
> > > >
> > > > We have an explicit check in the CI to ensure that both the author and the
> > > > committer have a SoB line. It's not base on checkpatch.pl. Ricardo,
> > > > could you confirm this ?
> > >
> > > CI checks that there are at least 2 committers that agree with the
> > > code (SoB, Reviewed-by or Ack-by)
> > > https://gitlab.freedesktop.org/linux-media/media-ci/-/blob/main/lib/test-trust.py?ref_type=heads
> > >
> > > We also have a separate check for SoB:
> > > https://gitlab.freedesktop.org/linux-media/media-ci/-/blob/main/test-media-patchstyle.sh?ref_type=heads#L61
> >
> > This script appears to be also ignoring .mailmap.
> test-trust does not ignore mailmap:
> https://gitlab.freedesktop.org/linux-media/media-ci/-/blob/main/lib/test-trust.py?ref_type=heads#L56

Ack, nice!

> 
> Do you see any scenario where the committer and the author are
> different users? "git commit" will set the same value for boths
> I am not against to modify the code if we find that usecase

Not apart from the From: e-mail address change due to .mailmap.

-- 
Kind regards,

Sakari Ailus