From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B269199FC9; Mon, 14 Oct 2024 11:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728905661; cv=none; b=e7CYRMEUPQUw+FOyEenH5GqO7BQZnvBQKeFF0Oeww2KJ7kDP36CoM+c5LLlxylQzu0j9ayZY9/Xn1SyUlWxQLX/Oezq/xohVBGuqirwGR9E8tJimhbGKs97YIkuHoHdD/Oe/b9KzduzNx4DVNK8g3Tmeep+TSnJCCtBipT8m0wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728905661; c=relaxed/simple; bh=leC8yKlYH4VNPM2C4uhTqo+xy0aVd69hjV1pJDYe5Fs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sDAAZqG/WnxsAnWs7wnWmezu1so2z55aGFXNenz2vX1AmxMMN6MtidYMmuCMiXT8rejbq1xLQAELtIuDHwNjPBaCNrMb1bFzjhnqExE/se2pHBFlhT807yuSondMKG9c3+rjkW/XyWgFhzAI3TQtuHZEdVNk1Nk5poq7i/1mTOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: x5PXqk6DQmWgUouKkadjQA== X-CSE-MsgGUID: 0WcgFxLAQf+V7bv1/HFEzg== X-IronPort-AV: E=McAfee;i="6700,10204,11224"; a="28380889" X-IronPort-AV: E=Sophos;i="6.11,202,1725346800"; d="scan'208";a="28380889" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 04:34:19 -0700 X-CSE-ConnectionGUID: olEkw6FRREO1uaLlY8DPUg== X-CSE-MsgGUID: o6UvEGmNSW6p3Fona3Ulkg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,202,1725346800"; d="scan'208";a="77199106" Received: from smile.fi.intel.com ([10.237.72.154]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 04:34:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1t0JL4-00000002sjn-2dPK; Mon, 14 Oct 2024 14:34:14 +0300 Date: Mon, 14 Oct 2024 14:34:14 +0300 From: Andy Shevchenko To: Colin Ian King Cc: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] media: atomisp: remove redundant re-checking of err Message-ID: References: <20241012141403.1558513-1-colin.i.king@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241012141403.1558513-1-colin.i.king@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sat, Oct 12, 2024 at 03:14:03PM +0100, Colin Ian King wrote: > The check to see if err is non-zero is always false because err has > been previously checked on whenever err has been assigned in previous > code paths. The check is redundant and can be removed. Reviewed-by: Andy Shevchenko All patches that end up in 100% minus lines statistics for this driver are so good! -- With Best Regards, Andy Shevchenko