From: Sasha Levin <sashal@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Lijo Lazar <lijo.lazar@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
sumit.semwal@linaro.org, mario.limonciello@amd.com,
Hawking.Zhang@amd.com, le.ma@amd.com, hamza.mahfooz@amd.com,
andrealmeid@igalia.com, victorchengchi.lu@amd.com,
sunil.khatri@amd.com, chenxb_99091@126.com,
victor.skvortsov@amd.com, Jun.Ma2@amd.com, Yunxiang.Li@amd.com,
Felix.Kuehling@amd.com, Arunpravin.PaneerSelvam@amd.com,
tvrtko.ursulin@igalia.com, pierre-eric.pelloux-prayer@amd.com,
Wang.Beyond@amd.com, shashank.sharma@amd.com,
zhenguo.yin@amd.com, jesse.zhang@amd.com, Philip.Yang@amd.com,
rajneesh.bhardwaj@amd.com, Tim.Huang@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH AUTOSEL 6.11 72/76] drm/amdgpu: nuke the VM PD/PT shadow handling
Date: Tue, 8 Oct 2024 09:04:39 -0400 [thread overview]
Message-ID: <ZwUt5zNpjTMzweM9@sashalap> (raw)
In-Reply-To: <bc1f6bc0-6512-48e0-9f97-c607b34e9ab1@amd.com>
On Tue, Oct 08, 2024 at 08:46:01AM +0200, Christian König wrote:
>Hi Sasha,
>
>Am 04.10.24 um 20:17 schrieb Sasha Levin:
>>From: Christian König <christian.koenig@amd.com>
>>
>>[ Upstream commit 7181faaa4703705939580abffaf9cb5d6b50dbb7 ]
>>
>>This was only used as workaround for recovering the page tables after
>>VRAM was lost and is no longer necessary after the function
>>amdgpu_vm_bo_reset_state_machine() started to do the same.
>>
>>Compute never used shadows either, so the only proplematic case left is
>>SVM and that is most likely not recoverable in any way when VRAM is
>>lost.
>
>why is that backported to older kernels? It's basically just removing
>an old and now unused feature.
>
>Lijo pointed out a related bug fixed by removing the feature, but that
>only happens extremely rarely and in my view doesn't really justify a
>backport.
I'll drop it then, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2024-10-08 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241004181828.3669209-1-sashal@kernel.org>
2024-10-04 18:17 ` [PATCH AUTOSEL 6.11 44/76] media: videobuf2-core: clear memory related fields in __vb2_plane_dmabuf_put() Sasha Levin
2024-10-04 18:17 ` [PATCH AUTOSEL 6.11 72/76] drm/amdgpu: nuke the VM PD/PT shadow handling Sasha Levin
2024-10-08 6:46 ` Christian König
2024-10-08 13:04 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwUt5zNpjTMzweM9@sashalap \
--to=sashal@kernel.org \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jun.Ma2@amd.com \
--cc=Philip.Yang@amd.com \
--cc=Tim.Huang@amd.com \
--cc=Wang.Beyond@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=Yunxiang.Li@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=chenxb_99091@126.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=jesse.zhang@amd.com \
--cc=le.ma@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=rajneesh.bhardwaj@amd.com \
--cc=shashank.sharma@amd.com \
--cc=stable@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=sunil.khatri@amd.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=victor.skvortsov@amd.com \
--cc=victorchengchi.lu@amd.com \
--cc=zhenguo.yin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox