From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/9] media: qcom: camss: remove .link_entities
Date: Tue, 13 May 2025 17:29:45 +0100 [thread overview]
Message-ID: <a032d182-141a-477e-b966-6477a24b015a@linaro.org> (raw)
In-Reply-To: <20250513142353.2572563-4-vladimir.zapolskiy@linaro.org>
On 13/05/2025 15:23, Vladimir Zapolskiy wrote:
> There is no potential for a custom .link_entities callback,
> remove it by replacing with a common camss_link_entities().
>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> drivers/media/platform/qcom/camss/camss.c | 14 +-------------
> drivers/media/platform/qcom/camss/camss.h | 1 -
> 2 files changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 8c844ebf9cb6..2977aeaf27e1 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -3143,7 +3143,6 @@ static int camss_init_subdevices(struct camss *camss)
> }
>
> /*
> - * camss_link_entities - Register subdev nodes and create links
> * camss_link_err - print error in case link creation fails
> * @src_name: name for source of the link
> * @sink_name: name for sink of the link
> @@ -3642,7 +3641,7 @@ static int camss_probe(struct platform_device *pdev)
> if (ret < 0)
> goto err_v4l2_device_unregister;
>
> - ret = camss->res->link_entities(camss);
> + ret = camss_link_entities(camss);
> if (ret < 0)
> goto err_register_subdevs;
>
> @@ -3726,7 +3725,6 @@ static const struct camss_resources msm8916_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_8x16),
> .csid_num = ARRAY_SIZE(csid_res_8x16),
> .vfe_num = ARRAY_SIZE(vfe_res_8x16),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources msm8953_resources = {
> @@ -3740,7 +3738,6 @@ static const struct camss_resources msm8953_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_8x96),
> .csid_num = ARRAY_SIZE(csid_res_8x53),
> .vfe_num = ARRAY_SIZE(vfe_res_8x53),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources msm8996_resources = {
> @@ -3752,7 +3749,6 @@ static const struct camss_resources msm8996_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_8x96),
> .csid_num = ARRAY_SIZE(csid_res_8x96),
> .vfe_num = ARRAY_SIZE(vfe_res_8x96),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources sdm660_resources = {
> @@ -3764,7 +3760,6 @@ static const struct camss_resources sdm660_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_660),
> .csid_num = ARRAY_SIZE(csid_res_660),
> .vfe_num = ARRAY_SIZE(vfe_res_660),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources sdm670_resources = {
> @@ -3775,7 +3770,6 @@ static const struct camss_resources sdm670_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_670),
> .csid_num = ARRAY_SIZE(csid_res_670),
> .vfe_num = ARRAY_SIZE(vfe_res_670),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources sdm845_resources = {
> @@ -3787,7 +3781,6 @@ static const struct camss_resources sdm845_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_845),
> .csid_num = ARRAY_SIZE(csid_res_845),
> .vfe_num = ARRAY_SIZE(vfe_res_845),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources sm8250_resources = {
> @@ -3801,7 +3794,6 @@ static const struct camss_resources sm8250_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_8250),
> .csid_num = ARRAY_SIZE(csid_res_8250),
> .vfe_num = ARRAY_SIZE(vfe_res_8250),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources sc8280xp_resources = {
> @@ -3816,7 +3808,6 @@ static const struct camss_resources sc8280xp_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_sc8280xp),
> .csid_num = ARRAY_SIZE(csid_res_sc8280xp),
> .vfe_num = ARRAY_SIZE(vfe_res_sc8280xp),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources sc7280_resources = {
> @@ -3830,7 +3821,6 @@ static const struct camss_resources sc7280_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_7280),
> .csid_num = ARRAY_SIZE(csid_res_7280),
> .vfe_num = ARRAY_SIZE(vfe_res_7280),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources sm8550_resources = {
> @@ -3845,7 +3835,6 @@ static const struct camss_resources sm8550_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_8550),
> .csid_num = ARRAY_SIZE(csid_res_8550),
> .vfe_num = ARRAY_SIZE(vfe_res_8550),
> - .link_entities = camss_link_entities
> };
>
> static const struct camss_resources x1e80100_resources = {
> @@ -3860,7 +3849,6 @@ static const struct camss_resources x1e80100_resources = {
> .csiphy_num = ARRAY_SIZE(csiphy_res_x1e80100),
> .csid_num = ARRAY_SIZE(csid_res_x1e80100),
> .vfe_num = ARRAY_SIZE(vfe_res_x1e80100),
> - .link_entities = camss_link_entities
> };
>
> static const struct of_device_id camss_dt_match[] = {
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index 63c0afee154a..1d0f83e4a2c9 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -107,7 +107,6 @@ struct camss_resources {
> const unsigned int csiphy_num;
> const unsigned int csid_num;
> const unsigned int vfe_num;
> - int (*link_entities)(struct camss *camss);
> };
>
> struct camss {
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2025-05-13 16:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 14:23 [PATCH 0/9] media: qcom: camss: a number of cleanups and fixes Vladimir Zapolskiy
2025-05-13 14:23 ` [PATCH 1/9] media: qcom: camss: cleanup media device allocated resource on error path Vladimir Zapolskiy
2025-06-13 15:36 ` Bryan O'Donoghue
2025-05-13 14:23 ` [PATCH 2/9] media: qcom: camss: remove duplicated csiphy_formats_sc7280 data Vladimir Zapolskiy
2025-05-13 16:30 ` Bryan O'Donoghue
2025-05-13 14:23 ` [PATCH 3/9] media: qcom: camss: remove .link_entities Vladimir Zapolskiy
2025-05-13 16:29 ` Bryan O'Donoghue [this message]
2025-05-13 14:23 ` [PATCH 4/9] media: qcom: camss: register camss media device before subdevices Vladimir Zapolskiy
2025-06-13 9:06 ` Bryan O'Donoghue
2025-06-17 16:14 ` Vladimir Zapolskiy
2025-06-23 9:24 ` neil.armstrong
2025-05-13 14:23 ` [PATCH 5/9] media: qcom: camss: unconditionally set async notifier of subdevices Vladimir Zapolskiy
2025-05-13 15:46 ` Bryan O'Donoghue
2025-05-14 15:16 ` Vladimir Zapolskiy
2025-05-15 9:25 ` Loic Poulain
2025-06-13 9:11 ` Bryan O'Donoghue
2025-06-17 16:22 ` Vladimir Zapolskiy
2025-06-23 9:26 ` neil.armstrong
2025-05-13 14:23 ` [PATCH 6/9] media: qcom: camss: simplify camss_subdev_notifier_complete() function Vladimir Zapolskiy
2025-06-13 9:13 ` Bryan O'Donoghue
2025-05-13 14:23 ` [PATCH 7/9] media: qcom: camss: change internals of endpoint parsing to fwnode handling Vladimir Zapolskiy
2025-06-13 9:30 ` Bryan O'Donoghue
2025-06-17 16:30 ` Vladimir Zapolskiy
2025-06-23 9:29 ` neil.armstrong
2025-06-23 12:00 ` Vladimir Zapolskiy
2025-05-13 14:23 ` [PATCH 8/9] media: qcom: camss: use a handy v4l2_async_nf_add_fwnode_remote() function Vladimir Zapolskiy
2025-05-13 14:23 ` [PATCH 9/9] MAINTAINERS: add myself as a CAMSS patch reviewer Vladimir Zapolskiy
2025-05-13 15:06 ` Bryan O'Donoghue
2025-06-06 10:52 ` [PATCH 0/9] media: qcom: camss: a number of cleanups and fixes Vladimir Zapolskiy
2025-06-10 17:26 ` Vladimir Zapolskiy
2025-06-10 18:53 ` Bryan O'Donoghue
2025-06-10 21:15 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a032d182-141a-477e-b966-6477a24b015a@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).