From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,x1e80100-camss: Sort interconnect alphabetically
Date: Tue, 10 Jun 2025 18:01:11 +0300 [thread overview]
Message-ID: <a14abbbd-c19a-4d9f-a888-3849acf7f045@linaro.org> (raw)
In-Reply-To: <tlaf6k4pblymc7zrsglgiugn4ft3bd2wwpmcghysmtnlb7grml@p6mqjkve3dvj>
On 6/10/25 17:44, Dmitry Baryshkov wrote:
> On Tue, Jun 10, 2025 at 03:42:05PM +0300, Vladimir Zapolskiy wrote:
>> On 6/10/25 14:11, Dmitry Baryshkov wrote:
>>> On Tue, Jun 10, 2025 at 11:33:17AM +0300, Vladimir Zapolskiy wrote:
>>>> Sort the entries of interconnect and interconnect-names lists in
>>>> alphabetical order.
>>>
>>> This looks like an ABI change. At least you should explain the reason
>>> for the patch.
>>
>> There was a number of comments and notes on the mailing list that
>> any changes to dt bindings without users are acceptable, i.e. no
>> users implies no ABI change.
>
> It is still an ABI change, but the one which usually has a waiver. And
> that's why it should be explained in the commit message.
I can resend the change with an update in its commit message stating
that it's an acceptable ABI change.
At once the Fixes tags could be removed, let it be a non-fix ABI change :)
>>
>> Also it was used as a justification to accept dt binding documentation
>> changes without the correspondent .dtsi changes, like in this particular
>> case. So, I believe the room for fixes is still open.
>
> Yes
>
>>
>>>>
>>>> Fixes: 2ab7f87a7f4b ("dt-bindings: media: Add qcom,x1e80100-camss")
>>>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>>> ---
>>>> Another fix on top of https://lore.kernel.org/all/20250502204142.2064496-1-vladimir.zapolskiy@linaro.org/
>>>
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2025-06-10 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 8:33 [PATCH 1/2] dt-bindings: media: qcom,x1e80100-camss: Sort interconnect alphabetically Vladimir Zapolskiy
2025-06-10 8:33 ` [PATCH 2/2] dt-bindings: media: qcom,x1e80100-camss: Fix isp unit address Vladimir Zapolskiy
2025-06-13 8:50 ` Bryan O'Donoghue
2025-06-28 0:12 ` Bryan O'Donoghue
2025-06-10 11:11 ` [PATCH 1/2] dt-bindings: media: qcom,x1e80100-camss: Sort interconnect alphabetically Dmitry Baryshkov
2025-06-10 12:42 ` Vladimir Zapolskiy
2025-06-10 14:44 ` Dmitry Baryshkov
2025-06-10 15:01 ` Vladimir Zapolskiy [this message]
2025-06-10 11:14 ` Bryan O'Donoghue
2025-06-10 12:45 ` Vladimir Zapolskiy
2025-06-10 15:02 ` Bryan O'Donoghue
2025-06-10 15:10 ` Vladimir Zapolskiy
2025-06-10 22:21 ` Dmitry Baryshkov
2025-06-10 23:00 ` Vladimir Zapolskiy
2025-06-25 19:51 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a14abbbd-c19a-4d9f-a888-3849acf7f045@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=hverkuil@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox