Re: Kaffeine commit b510bff2 won't compile

[bill murphy <gc2majortom@gmail.com>]

Hi Mauro,

Thanks for looking in to it. All is well now.

On a sidenote, given 700 MHz is used for LTE, and not broadcasting

anymore, would you folks consider removing ch 52 thru 69

in the us-atsc-frequencies if I posted a simple patch to dtv-scan-tables?


Bill

On 02/27/2017 05:11 AM, Mauro Carvalho Chehab wrote:
> Em Sun, 26 Feb 2017 20:57:20 -0500
> bill murphy <gc2majortom@gmail.com> escreveu:
>
>> Hi,
>> Can someone double check me on this?
>>
>> It seems there might be a missing header,
>> in the src directory, preventing the last commit from
>> compiling. The commit prior compiles fine. So not that big a deal, just
>> letting folks know what I ran in to.
>>
>> I don't see this file, 'log.h', anywhere in the src directory. Guessing
>> it wasn't 'added' for tracking?
>>
>> git://anongit.kde.org/kaffeine
>>
>> diff between master and previous commit...just a snippet, as other files
>> are including the same missing header.
>>
>> diff --git a/src/dvb/dvbcam_linux.cpp b/src/dvb/dvbcam_linux.cpp
>> index ceb9dbd..5c9c575 100644
>> --- a/src/dvb/dvbcam_linux.cpp
>> +++ b/src/dvb/dvbcam_linux.cpp
>> @@ -18,11 +18,7 @@
>>     * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>>     */
>>
>> -#include <KLocalizedString>
>> -#include <QDebug>
>> -#if QT_VERSION < 0x050500
>> -# define qInfo qDebug
>> -#endif
>> +#include "../log.h"
>>
>>    #include <errno.h>
>>    #include <fcntl.h>
>>
>> where compile complains of that missing header...
>>
>> Scanning dependencies of target kaffeine
>> [ 20%] Building CXX object
>> src/CMakeFiles/kaffeine.dir/dvb/dvbcam_linux.cpp.o
>> /home/user/src2/kaffeine/src/dvb/dvbcam_linux.cpp:21:20: fatal error:
>> ../log.h: No such file or directory
>> compilation terminated.
> Thanks for complaining about it! I forgot to add src/log.h on the
> commit.
>
> You should be able to compile it now.
>
> Thanks,
> Mauro