From: "Helmut Auer" <vdr@helmutauer.de>
To: "Sean Young" <sean@mess.org>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] [MEDIA] add device ID to ati remote
Date: Tue, 14 Feb 2017 08:11:56 +0100 [thread overview]
Message-ID: <a3094b0048a1ce3f295417e9330e1194.squirrel@helmutauer.de> (raw)
In-Reply-To: <20170213134244.GA18860@gofer.mess.org>
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
P.S. Here is the patch again with a correction.
> On Tue, Feb 07, 2017 at 09:42:47AM +0100, vdr@helmutauer.de wrote:
>>
>> Author: Helmut Auer <vdr@xxx.de>
>> Date: Fri Jan 27 19:09:35 2017 +0100
>>
>> Adding 1 device ID to ati_remote driver.
>
> If possible, a more descriptive message would be preferred, e.g. what
> device do you have, what branding, what product did it come with.
>
>>
>> Signed-off-by: Helmut Auer <vdr@xxx.de>
>
> Unless I'm mistaken, contributions can't be anonymous or use a fake email
> address.
>
>>
>> diff --git a/drivers/media/rc/ati_remote.c
>> b/drivers/media/rc/ati_remote.c
>> index 0884b7d..83022b1 100644
>> --- a/drivers/media/rc/ati_remote.c
>> +++ b/drivers/media/rc/ati_remote.c
>> @@ -108,6 +108,7 @@
>> #define NVIDIA_REMOTE_PRODUCT_ID 0x0005
>> #define MEDION_REMOTE_PRODUCT_ID 0x0006
>> #define FIREFLY_REMOTE_PRODUCT_ID 0x0008
>> +#define REYCOM_REMOTE_PRODUCT_ID 0x000c
>>
>> #define DRIVER_VERSION "2.2.1"
>> #define DRIVER_AUTHOR "Torrey Hoffman <thoffman@arnor.net>"
>> @@ -227,6 +228,10 @@ static struct usb_device_id ati_remote_table[] = {
>> USB_DEVICE(ATI_REMOTE_VENDOR_ID,
>> FIREFLY_REMOTE_PRODUCT_ID),
>> .driver_info = (unsigned long)&type_firefly
>> },
>> + {
>> + USB_DEVICE(ATI_REMOTE_VENDOR_ID,
>> REYCOM_REMOTE_PRODUCT_ID),
>> + .driver_info = (unsigned long)&type_firefly
>> + },
>> {} /* Terminating entry */
>> };
>
> Your email client replaced all tabs with spaces so the patch no longer
> applies.
>
> Thanks,
> Sean
>
[-- Attachment #2: 015_atireycom.patch --]
[-- Type: application/octet-stream, Size: 721 bytes --]
--- drivers/media/rc/ati_remote.c 2016-12-11 20:17:54.000000000 +0100
+++ drivers/media/rc/ati_remote.c 2017-02-07 08:39:25.860644177 +0100
@@ -108,6 +108,7 @@
#define NVIDIA_REMOTE_PRODUCT_ID 0x0005
#define MEDION_REMOTE_PRODUCT_ID 0x0006
#define FIREFLY_REMOTE_PRODUCT_ID 0x0008
+#define REYCOM_REMOTE_PRODUCT_ID 0x000c
#define DRIVER_VERSION "2.2.1"
#define DRIVER_AUTHOR "Torrey Hoffman <thoffman@arnor.net>"
@@ -227,6 +228,10 @@
USB_DEVICE(ATI_REMOTE_VENDOR_ID, FIREFLY_REMOTE_PRODUCT_ID),
.driver_info = (unsigned long)&type_firefly
},
+ {
+ USB_DEVICE(ATI_REMOTE_VENDOR_ID, REYCOM_REMOTE_PRODUCT_ID),
+ .driver_info = (unsigned long)&type_medion
+ },
{} /* Terminating entry */
};
next prev parent reply other threads:[~2017-02-14 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 8:06 [patch] [media] mantis_dvb: fix some error codes in mantis_dvb_init() Dan Carpenter
2017-01-27 8:15 ` [patch] [media] add device IDs to ngene vdr
2017-01-27 13:20 ` [PATCH] [MEDIA] " vdr
2017-02-07 8:42 ` [PATCH] [MEDIA] add device ID to ati remote vdr
2017-02-13 13:42 ` Sean Young
2017-02-13 22:57 ` Helmut Auer
2017-02-14 7:11 ` Helmut Auer [this message]
2017-02-14 7:20 ` [PATCH] [MEDIA] add device IDs to ngene driver Helmut Auer
2017-01-27 8:29 ` [patch] [media] mantis_dvb: fix some error codes in mantis_dvb_init() walter harms
2017-01-27 9:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3094b0048a1ce3f295417e9330e1194.squirrel@helmutauer.de \
--to=vdr@helmutauer.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).