From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0EAA349AF5 for ; Fri, 10 Apr 2026 13:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775828844; cv=none; b=q91tXThxFYgyxpwrxcUh5Jc9MQsWPTYZ0xpRWfPYhtfo+QlJc62oslik9MTtu8kH2IGPjVHI5lrs15QIdtqbytJ7Yt8q15/fcWvVQUiZoZCsFzBGLFXh3j+x11S10iPAe38StJXeDPY1ZcU//xcULgFqEGqtjFltxVoLXkfeYtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775828844; c=relaxed/simple; bh=/9YLiHSlBBeuUGksZZmIRHaHg0NDtKgpl9Pv1O1q8nk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=pA+JFCLh4DCnxOBNAfXpZzox1TwbuxIcuU2uGyoLqqb/Ho3Z2YNyTSt20jVAZTmteWEMcUA5A5aUWffzPxFkHjSUfj/8BkzuH3/NxPk9hXEUzHA9SdPYYmCUYCP9hbpOznQq2kmxWbT2bnbHE1W+IzZEvGFXYAvEs2q4lD35u0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GtZTyJ/0; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GtZTyJ/0" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso20582695e9.1 for ; Fri, 10 Apr 2026 06:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775828841; x=1776433641; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=HY0v9vnNB0cSghEPTbRdLaX/P/UJ93BNk17g46Nvi8A=; b=GtZTyJ/0WAG4QWoU7yQ0vZA9Y3eXg71UJx+KGIBAif/TW82fYOgkhQS6vhqw1t90hf 5jRyzMA4Nz9slTNKP6VBOOmC7GdLm3zyFi8zXcFduXnqTG9OoiErX/ibw3xhSYN7Vrmn PSlRytAxsq6Lfi+lK2REIp4f7P9pvVKG6dFE+jzXmDWvQOeRuARcTKv/HP6yuYoOqw/q WOTMHdS8NxU8SrwPcQM3kMOhZ0wZX7QIYRb5bUUPPAnIbO1yfYhLBhwqkD6gXwn21Uey KYwlL3A8dSNgCgbYKL6Ii0KPqqjYKD9JEsMKhGk5DPE0G0MfZbgv3+WZT+1oiF/VHkuT YGPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775828841; x=1776433641; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HY0v9vnNB0cSghEPTbRdLaX/P/UJ93BNk17g46Nvi8A=; b=hU4UqKIClR3NQGhureR4+m3El7s2gYDAQWstRG2j6j/02XRBAAm0/CjDr4xphjVYDP 1RKPC1xRvhUSsCpH5okefzLv+yxQTtLcHMna2VzHGwKhmPbGlV1GhbZKjzuxMy7o5iEZ HbVZ8eMfRF1x0ziAvwChOGRzjH0LMU7tanMJjPY/SzZe7Rx+P4pFiH0GvgC0wiTMgH8n omv/ozFfg4lDlXt5tsabMXX+ujSUUlCPSJNf+RUdrqNhFnEAmt2KF/O6ifSt0TZKTBC3 JzTjyZQ7MtqiLp7C+3usePWoqIeVaa+pu3gjFx0IKYdzkQPXNkTrT6MeEBxRVNi91Pl4 uhug== X-Gm-Message-State: AOJu0YxudgOn0NvhNumeZM34TGVzUQttkIJmdCiXGClKOaey0B2Wuhp0 2ZpTrPK+lJ0+1xQa8DnHlT08LM8kcWbp9EUsOgweV0Xkx3iGhQjCZQEjc90td02anIg= X-Gm-Gg: AeBDievZhEOuUGrB16hK42UUsxynrEvWsYPaS3e8Kn78agGs6eRSHhni4rBOQfhRyXj 0O4dCZEn1YAjkU+Xzy+PFSxORlD8+/SzNIh14EFnH2wmi0oN8T+TRcX7BZix77DPMsL06xp3mPq eHJ9rWAkRRERRwxRAg/xWOnkDUAMIP50ILsGDMXF/hKf/YezGv1gTWC74I356ZdpL6C6C9aBGN8 noUDQ66s7y0wqj1nzN46y4yNHmwkUOZQn5ZXvjdGU4WSaSUJvk/2lkRYVNX+aH8ruc1qhyVdt9i MF7hxJq9xntuhARtLH+IWUBu1V18+Y4ugqu0aEPqrNx693eZsGCM2MxvLpvQNivGBbijnM16Eh9 vMLB8FuAgK3HbIHhI2IwU8SxxTAYFPdEDeawCgkwIb8Dd1/A9tJF8amWzSmLhc/CLAXbSSo+e00 tlsQee112ZN4abyiw2SQSOqJuPy3Yvf6PAfLPlQYjuYggT59GjOkFsJfPHCtEAujmZITLRYPwFP jyZOM8= X-Received: by 2002:a05:600c:674f:b0:488:a82f:bb9b with SMTP id 5b1f17b1804b1-488d68cb47amr45964215e9.30.1775828841015; Fri, 10 Apr 2026 06:47:21 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:c8e5:d5af:c912:c512? ([2a01:e0a:106d:1080:c8e5:d5af:c912:c512]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5da1341sm22552125e9.8.2026.04.10.06.47.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 06:47:20 -0700 (PDT) Message-ID: Date: Fri, 10 Apr 2026 15:47:19 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH RFC 4/7] media: qcom: iris: vdec: update size and stride calculations for 10bit formats To: Vishnu Reddy , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org> <20260408-topic-sm8x50-iris-10bit-decoding-v1-4-428c1ec2e3f3@linaro.org> <99eb55a8-6370-bf7b-f9de-e88231454b0e@oss.qualcomm.com> <0301bf82-0859-44cd-99df-3de997e2cff4@linaro.org> <7db19009-4e33-945e-789e-689b72c39aa5@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <7db19009-4e33-945e-789e-689b72c39aa5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/10/26 14:57, Vishnu Reddy wrote: > > On 4/10/2026 5:29 PM, Neil Armstrong wrote: >> On 4/10/26 12:10, Vishnu Reddy wrote: >>> >>> On 4/8/2026 10:13 PM, Neil Armstrong wrote: >>>> Update the gen2 response and vdec s_fmt code to take in account >>>> the P010 and QC010 when calculating the width, height and stride. >>>> >>>> Signed-off-by: Neil Armstrong >>>> --- >>>>   .../platform/qcom/iris/iris_hfi_gen2_response.c     | 19 ++++++++++++++++--- >>>>   drivers/media/platform/qcom/iris/iris_vdec.c        | 21 ++++++++++++++++++--- >>>>   2 files changed, 34 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >>>> index 8e19f61bbbf9..d268149191ea 100644 >>>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >>>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >>>> @@ -542,9 +542,22 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst) >>>>       pixmp_ip->width = width; >>>>       pixmp_ip->height = height; >>>> -    pixmp_op->width = ALIGN(width, 128); >>>> -    pixmp_op->height = ALIGN(height, 32); >>>> -    pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); >>>> +    pixmp_op->width = pixmp_op->pixelformat == V4L2_PIX_FMT_QC10C ? >>>> +        ALIGN(width, 192) : ALIGN(width, 128); >>>> +    pixmp_op->height = pixmp_op->pixelformat == V4L2_PIX_FMT_QC10C ? >>>> +        ALIGN(height, 16) : ALIGN(height, 32); >>>> +    switch (pixmp_op->pixelformat) { >>>> +    case V4L2_PIX_FMT_P010: >>>> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256); >>>> +        break; >>>> +    case V4L2_PIX_FMT_QC10C: >>>> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(ALIGN(width, 192) * 4 / 3, 256); >>>> +        break; >>>> +    case V4L2_PIX_FMT_NV12: >>>> +    case V4L2_PIX_FMT_QC08C: >>>> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); >>>> +        break; >>>> +    } >>>>       pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); >>>>       matrix_coeff = subsc_params.color_info & 0xFF; >>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c >>>> index 719217399a30..ca0518c27834 100644 >>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c >>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c >>>> @@ -272,10 +272,25 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f) >>>>           fmt = inst->fmt_dst; >>>>           fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; >>>>           fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat; >>>> -        fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >>>> -        fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >>>> +        codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 192 : 128; >>>> +        fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, codec_align); >>>> +        codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 16 : 32; >>>> +        fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, codec_align); >>>>           fmt->fmt.pix_mp.num_planes = 1; >>>> -        fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f->fmt.pix_mp.width, 128); >>>> +        switch (f->fmt.pix_mp.pixelformat) { >>>> +        case V4L2_PIX_FMT_P010: >>>> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >>>> +                ALIGN(f->fmt.pix_mp.width * 2, 256); >>>> +            break; >>>> +        case V4L2_PIX_FMT_QC10C: >>>> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >>>> +                ALIGN(f->fmt.pix_mp.width * 4 / 3, 256); >>>> +            break; >>>> +        case V4L2_PIX_FMT_NV12: >>>> +        case V4L2_PIX_FMT_QC08C: >>>> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = f->fmt.pix_mp.width; >>> In the removed code, bytesperline for NV12 and QC08C was aligned to 128 bytes. >>> In the new code, Is that alignment missed or not required? >> >> The alignment is done right before: >>     codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 192 : 128; >>     fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, codec_align); >> >> calling ALIGN(f->fmt.pix_mp.width, 128) again is a no-op. >> > Here f->fmt.pix_mp.width is not aligned, fmt->fmt.pix_mp.width is aligned. > It should be fmt->fmt.pix_mp.plane_fmt[0].bytesperline = fmt->fmt.pix_mp.width. Indeed you're right, I did misread... Thanks, Neil > > Thanks, > Vishnu Reddy >> Thanks, >> Neil >> >>>> +            break; >>>> +        } >>>>           fmt->fmt.pix_mp.plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); >>>>           inst->buffers[BUF_OUTPUT].min_count = iris_vpu_buf_count(inst, BUF_OUTPUT); >>>>           inst->buffers[BUF_OUTPUT].size = fmt->fmt.pix_mp.plane_fmt[0].sizeimage; >>>> >>