From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F234117BA3 for ; Fri, 10 May 2024 18:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715365667; cv=none; b=XJfTR7kWOmOBT+Uo5lYvNoFlvmxaVF+7B+/hpgcglfaOnS4tSNTclKZb0YctgxgQsAIkbNo3cxpWXg7hKCMKoYl0fZhZme6zf3bZN25aiawarz4TSbUcI7GgOB1N8yO1p442N1/4G6DSZMHcs3uuh/9MPhmp+Bi72SKokyqlC8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715365667; c=relaxed/simple; bh=uLqe92/dQ4dMxvG6UINLCSdWA9vxn9F9HhspNog0qfE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tp5mhoUXFzNpYLxNmmgXbqpJ+Az7nPLRQOgLMSP6zXWHk6eKNfB6vF9hCYxvuKYNxCaBFI1TtgMwWJwVQ8R5doN7UrPfjX5SJ6GNkCL+8MxeKsKAL+IUdY2iNJ0DI2xJYwIFGwzgQ3NtF9dO46yGVo4yS3V+ORamblHPLLXrAGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VZRV8ygJ; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VZRV8ygJ" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2e3fa13f018so28127091fa.3 for ; Fri, 10 May 2024 11:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715365664; x=1715970464; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N5gysLK7eBXrdS+RL9/zVN/Yqx4/fP1l7kizHDddPSA=; b=VZRV8ygJzcWS1QwM5oX65XYyIca6fJ3O6IIIRltWw26KVUvQaHNj+dSXv9WSoyTnxp IjLQ7qW91QFuqZXt/zX87OI30HRJ1DYTojolgq0kM/SUUYUy5wyu4ZP6CaTBuQd6YeC4 wZ9vKxjn+e+6IwzU2Mrwfr7mJ3I/ih4aou1IWLlL4VWDzFbDi9AodfOy/UYgDUgspJ88 PjHHX114v1sA4Re2jKt+6M3FQhrmZCBfUVKig7GqAHEGzN1Z+D1UmnNrP2UT1s71H0ly Y2DGVC93tthBI/iCjdA7UQinTZxBkvZIBhQ4jLNg4DHX1XnpMrWxxanMSI4TxPlkFXfF xGxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715365664; x=1715970464; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N5gysLK7eBXrdS+RL9/zVN/Yqx4/fP1l7kizHDddPSA=; b=rD8krQlN+cnrej15N+pcmuZ9mOR0qQ5/IEJacCQ37oDtCwRJirA8AXn9nDpX/8uc5a qQ02JHB90TZ80X8ZiNBfYJqRgmidtV+86GAK2f7ndkZmsR+sgTw9o+IhlCf2LAbkJfQN K9DWu+OESZGVcDEwmxrZRqnOHteLCK28yc9h/rPrB8rXRylZYV2/h0TbOMScEWzF/NgN uxmazlVQnrc4f7XbiYt9pe1VkM5rtDvrjp7Zk99Xg3IBQGSA+kLXGvtXJb9b/iNy4dR6 W9uGNZ0gGfXZ2mQSptY2XHM6hdzNKU294aR+qbmnOG9D2MmbxE0etHKQspwKQ81uHJkw whWA== X-Gm-Message-State: AOJu0Yyun51xYY7BGS0pjESea8NewLe/xnle7jzY+xbaQMtdiqRF+J22 bX79CIMkBzch+bEgEUwntw95T98Kahx3UKA2lxtfKW5lHtk52ONesSD9gQQBtr4= X-Google-Smtp-Source: AGHT+IEMygHGPRkk63RA6oaXPAij4I7QO4Qy+Nr1+oXenXLN8w5lR7lfJFLWFrG4aC3QZc8TmW1q+Q== X-Received: by 2002:a05:651c:c9:b0:2de:73b5:4280 with SMTP id 38308e7fff4ca-2e51fd2de83mr24891861fa.3.1715365664318; Fri, 10 May 2024 11:27:44 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccce25d5sm72370325e9.14.2024.05.10.11.27.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 May 2024 11:27:44 -0700 (PDT) Message-ID: Date: Fri, 10 May 2024 19:27:43 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] media: qcom: camss: Attach formats to CSID resources To: Gjorgji Rosikopulos , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl, quic_hariramp@quicinc.com References: <20240411124543.199-1-quic_grosikop@quicinc.com> <20240411124543.199-4-quic_grosikop@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240411124543.199-4-quic_grosikop@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/04/2024 13:45, Gjorgji Rosikopulos wrote: > From: Radoslav Tsvetkov > > Following the example of VFE, move all formats of the decoder > to camss-csid.c and attach them to the subdevices resources. > > Signed-off-by: Radoslav Tsvetkov > Signed-off-by: Gjorgji Rosikopulos > --- > .../platform/qcom/camss/camss-csid-4-1.c | 132 +---- > .../platform/qcom/camss/camss-csid-4-7.c | 160 +----- > .../platform/qcom/camss/camss-csid-gen2.c | 164 +----- > .../media/platform/qcom/camss/camss-csid.c | 474 +++++++++++++++++- > .../media/platform/qcom/camss/camss-csid.h | 24 +- > drivers/media/platform/qcom/camss/camss.c | 75 ++- > 6 files changed, 538 insertions(+), 491 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-4-1.c b/drivers/media/platform/qcom/camss/camss-csid-4-1.c > index dd49a40e6a70..c95861420502 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-4-1.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-4-1.c Reviewed-by: Bryan O'Donoghue Tested-by: Bryan O'Donoghue # sc8280xp/sm8250/sdm845/apq8016