Re: [PATCH 6/8] media: staging/ipu7: add IPU7 input system device driver

[Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>]

Hi

On Tue, Apr 29, 2025 at 11:28:39AM +0800, bingbu.cao@intel.com wrote:
> +unsigned int ipu7_isys_mbus_code_to_bpp(u32 code)
> +{
> +	switch (code) {
> +	case MEDIA_BUS_FMT_RGB888_1X24:
> +		return 24;
> +	case MEDIA_BUS_FMT_YUYV10_1X20:
> +		return 20;
> +	case MEDIA_BUS_FMT_Y10_1X10:
> +	case MEDIA_BUS_FMT_RGB565_1X16:
> +	case MEDIA_BUS_FMT_UYVY8_1X16:
> +	case MEDIA_BUS_FMT_YUYV8_1X16:
> +		return 16;
> +	case MEDIA_BUS_FMT_SBGGR12_1X12:
> +	case MEDIA_BUS_FMT_SGBRG12_1X12:
> +	case MEDIA_BUS_FMT_SGRBG12_1X12:
> +	case MEDIA_BUS_FMT_SRGGB12_1X12:
> +		return 12;
> +	case MEDIA_BUS_FMT_SBGGR10_1X10:
> +	case MEDIA_BUS_FMT_SGBRG10_1X10:
> +	case MEDIA_BUS_FMT_SGRBG10_1X10:
> +	case MEDIA_BUS_FMT_SRGGB10_1X10:
> +		return 10;
> +	case MEDIA_BUS_FMT_SBGGR8_1X8:
> +	case MEDIA_BUS_FMT_SGBRG8_1X8:
> +	case MEDIA_BUS_FMT_SGRBG8_1X8:
> +	case MEDIA_BUS_FMT_SRGGB8_1X8:
> +		return 8;
> +	default:
> +		WARN_ON(1);
> +		return -EINVAL;
> +	}
> +}

We return negative error but return type is unsigned. 
Also we do not check for error on ipu7_isys_setup_video()
when calling this function.

Regards
Stanislaw