* [PATCH v2 0/2] media: renesas: rzg2l-cru: Fix FIFO empty check and typo @ 2025-04-29 9:16 Prabhakar 2025-04-29 9:16 ` [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check Prabhakar 2025-04-29 9:16 ` [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name Prabhakar 0 siblings, 2 replies; 9+ messages in thread From: Prabhakar @ 2025-04-29 9:16 UTC (permalink / raw) To: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil Cc: linux-media, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das, Fabrizio Castro, Tommaso Merciai, Lad Prabhakar From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi All, This patch series addresses two minor issues in the rzg2l-cru driver: 1. Simplifies the FIFO empty check by collapsing the redundant `if` statement into a single return statement, improving readability without changing behavior. 2. Fixes a typo in the function name `rzg3e_fifo_empty` to `rzg2l_fifo_empty`. v1->v2: - The commit message for the first patch has been updated to clarify the changes made. - Patch 2/2 is new v1: https://lore.kernel.org/all/20250428095208.99062-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar Lad Prabhakar (2): media: renesas: rzg2l-cru: Simplify FIFO empty check media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 2 +- drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 +- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) -- 2.49.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check 2025-04-29 9:16 [PATCH v2 0/2] media: renesas: rzg2l-cru: Fix FIFO empty check and typo Prabhakar @ 2025-04-29 9:16 ` Prabhakar 2025-04-29 14:24 ` Geert Uytterhoeven ` (2 more replies) 2025-04-29 9:16 ` [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name Prabhakar 1 sibling, 3 replies; 9+ messages in thread From: Prabhakar @ 2025-04-29 9:16 UTC (permalink / raw) To: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil Cc: linux-media, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das, Fabrizio Castro, Tommaso Merciai, Lad Prabhakar, Dan Carpenter From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Collapse FIFO empty helper into a single return statement by removing the redundant `if (amnfifopntr_w == amnfifopntr_r_y) return true;` path. Make `rzg2l_fifo_empty()` directly return `amnfifopntr_w == amnfifopntr_r_y` to improve readability without changing behavior. Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/all/aAtQThCibZCROETx@stanley.mountain/ Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 067c6af14e95..3d0810b3c35e 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -345,8 +345,6 @@ bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru) amnfifopntr_w = amnfifopntr & AMnFIFOPNTR_FIFOWPNTR; amnfifopntr_r_y = (amnfifopntr & AMnFIFOPNTR_FIFORPNTR_Y) >> 16; - if (amnfifopntr_w == amnfifopntr_r_y) - return true; return amnfifopntr_w == amnfifopntr_r_y; } -- 2.49.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check 2025-04-29 9:16 ` [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check Prabhakar @ 2025-04-29 14:24 ` Geert Uytterhoeven 2025-04-30 9:11 ` Tommaso Merciai 2025-06-18 10:09 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Geert Uytterhoeven @ 2025-04-29 14:24 UTC (permalink / raw) To: Prabhakar Cc: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro, Tommaso Merciai, Lad Prabhakar, Dan Carpenter On Tue, 29 Apr 2025 at 11:16, Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Collapse FIFO empty helper into a single return statement by removing the > redundant `if (amnfifopntr_w == amnfifopntr_r_y) return true;` path. Make > `rzg2l_fifo_empty()` directly return `amnfifopntr_w == amnfifopntr_r_y` > to improve readability without changing behavior. > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/all/aAtQThCibZCROETx@stanley.mountain/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check 2025-04-29 9:16 ` [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check Prabhakar 2025-04-29 14:24 ` Geert Uytterhoeven @ 2025-04-30 9:11 ` Tommaso Merciai 2025-06-18 10:09 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Tommaso Merciai @ 2025-04-30 9:11 UTC (permalink / raw) To: Prabhakar Cc: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar, Dan Carpenter On Tue, Apr 29, 2025 at 10:16:08AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Collapse FIFO empty helper into a single return statement by removing the > redundant `if (amnfifopntr_w == amnfifopntr_r_y) return true;` path. Make > `rzg2l_fifo_empty()` directly return `amnfifopntr_w == amnfifopntr_r_y` > to improve readability without changing behavior. > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/all/aAtQThCibZCROETx@stanley.mountain/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> Thanks & Regards, Tommaso > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 067c6af14e95..3d0810b3c35e 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -345,8 +345,6 @@ bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru) > amnfifopntr_w = amnfifopntr & AMnFIFOPNTR_FIFOWPNTR; > amnfifopntr_r_y = > (amnfifopntr & AMnFIFOPNTR_FIFORPNTR_Y) >> 16; > - if (amnfifopntr_w == amnfifopntr_r_y) > - return true; > > return amnfifopntr_w == amnfifopntr_r_y; > } > -- > 2.49.0 > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check 2025-04-29 9:16 ` [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check Prabhakar 2025-04-29 14:24 ` Geert Uytterhoeven 2025-04-30 9:11 ` Tommaso Merciai @ 2025-06-18 10:09 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Laurent Pinchart @ 2025-06-18 10:09 UTC (permalink / raw) To: Prabhakar Cc: Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro, Tommaso Merciai, Lad Prabhakar, Dan Carpenter On Tue, Apr 29, 2025 at 10:16:08AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Collapse FIFO empty helper into a single return statement by removing the > redundant `if (amnfifopntr_w == amnfifopntr_r_y) return true;` path. Make > `rzg2l_fifo_empty()` directly return `amnfifopntr_w == amnfifopntr_r_y` > to improve readability without changing behavior. > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/all/aAtQThCibZCROETx@stanley.mountain/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 067c6af14e95..3d0810b3c35e 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -345,8 +345,6 @@ bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru) > amnfifopntr_w = amnfifopntr & AMnFIFOPNTR_FIFOWPNTR; > amnfifopntr_r_y = > (amnfifopntr & AMnFIFOPNTR_FIFORPNTR_Y) >> 16; > - if (amnfifopntr_w == amnfifopntr_r_y) > - return true; > > return amnfifopntr_w == amnfifopntr_r_y; > } -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name 2025-04-29 9:16 [PATCH v2 0/2] media: renesas: rzg2l-cru: Fix FIFO empty check and typo Prabhakar 2025-04-29 9:16 ` [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check Prabhakar @ 2025-04-29 9:16 ` Prabhakar 2025-04-29 14:26 ` Geert Uytterhoeven ` (2 more replies) 1 sibling, 3 replies; 9+ messages in thread From: Prabhakar @ 2025-04-29 9:16 UTC (permalink / raw) To: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil Cc: linux-media, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das, Fabrizio Castro, Tommaso Merciai, Lad Prabhakar From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Correct the misnamed FIFO-empty helper for the RZ/G3E CRU. Rename `rz3e_fifo_empty` to `rzg3e_fifo_empty` to match the intended naming convention. Reported-by: Biju Das <biju.das.jz@bp.renesas.com> Closes: https://lore.kernel.org/all/TY3PR01MB11346E57A3DF8D8A90A405E4686812@TY3PR01MB11346.jpnprd01.prod.outlook.com/ Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 2 +- drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 +- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index 5fa73ab2db53..db27819d8200 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -366,7 +366,7 @@ static const struct rzg2l_cru_info rzg3e_cru_info = { .irq_handler = rzg3e_cru_irq, .enable_interrupts = rzg3e_cru_enable_interrupts, .disable_interrupts = rzg3e_cru_disable_interrupts, - .fifo_empty = rz3e_fifo_empty, + .fifo_empty = rzg3e_fifo_empty, .csi_setup = rzg3e_cru_csi2_setup, }; diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h index c30f3b281284..56feda6e6207 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h @@ -199,7 +199,7 @@ void rzg3e_cru_enable_interrupts(struct rzg2l_cru_dev *cru); void rzg3e_cru_disable_interrupts(struct rzg2l_cru_dev *cru); bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru); -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru); +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru); void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, const struct rzg2l_cru_ip_format *ip_fmt, u8 csi_vc); diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 3d0810b3c35e..ab35caf97c51 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -323,7 +323,7 @@ static int rzg2l_cru_initialize_image_conv(struct rzg2l_cru_dev *cru, return 0; } -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru) +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru) { u32 amnfifopntr = rzg2l_cru_read(cru, AMnFIFOPNTR); -- 2.49.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name 2025-04-29 9:16 ` [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name Prabhakar @ 2025-04-29 14:26 ` Geert Uytterhoeven 2025-04-30 9:12 ` Tommaso Merciai 2025-06-18 10:10 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Geert Uytterhoeven @ 2025-04-29 14:26 UTC (permalink / raw) To: Prabhakar Cc: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro, Tommaso Merciai, Lad Prabhakar On Tue, 29 Apr 2025 at 11:17, Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Correct the misnamed FIFO-empty helper for the RZ/G3E CRU. Rename > `rz3e_fifo_empty` to `rzg3e_fifo_empty` to match the intended > naming convention. > > Reported-by: Biju Das <biju.das.jz@bp.renesas.com> > Closes: https://lore.kernel.org/all/TY3PR01MB11346E57A3DF8D8A90A405E4686812@TY3PR01MB11346.jpnprd01.prod.outlook.com/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name 2025-04-29 9:16 ` [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name Prabhakar 2025-04-29 14:26 ` Geert Uytterhoeven @ 2025-04-30 9:12 ` Tommaso Merciai 2025-06-18 10:10 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Tommaso Merciai @ 2025-04-30 9:12 UTC (permalink / raw) To: Prabhakar Cc: Laurent Pinchart, Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar On Tue, Apr 29, 2025 at 10:16:09AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Correct the misnamed FIFO-empty helper for the RZ/G3E CRU. Rename > `rz3e_fifo_empty` to `rzg3e_fifo_empty` to match the intended > naming convention. > > Reported-by: Biju Das <biju.das.jz@bp.renesas.com> > Closes: https://lore.kernel.org/all/TY3PR01MB11346E57A3DF8D8A90A405E4686812@TY3PR01MB11346.jpnprd01.prod.outlook.com/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> Thanks & Regards, Tommaso > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 2 +- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 +- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > index 5fa73ab2db53..db27819d8200 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > @@ -366,7 +366,7 @@ static const struct rzg2l_cru_info rzg3e_cru_info = { > .irq_handler = rzg3e_cru_irq, > .enable_interrupts = rzg3e_cru_enable_interrupts, > .disable_interrupts = rzg3e_cru_disable_interrupts, > - .fifo_empty = rz3e_fifo_empty, > + .fifo_empty = rzg3e_fifo_empty, > .csi_setup = rzg3e_cru_csi2_setup, > }; > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > index c30f3b281284..56feda6e6207 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > @@ -199,7 +199,7 @@ void rzg3e_cru_enable_interrupts(struct rzg2l_cru_dev *cru); > void rzg3e_cru_disable_interrupts(struct rzg2l_cru_dev *cru); > > bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru); > -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru); > +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru); > void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, > const struct rzg2l_cru_ip_format *ip_fmt, > u8 csi_vc); > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 3d0810b3c35e..ab35caf97c51 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -323,7 +323,7 @@ static int rzg2l_cru_initialize_image_conv(struct rzg2l_cru_dev *cru, > return 0; > } > > -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru) > +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru) > { > u32 amnfifopntr = rzg2l_cru_read(cru, AMnFIFOPNTR); > > -- > 2.49.0 > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name 2025-04-29 9:16 ` [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name Prabhakar 2025-04-29 14:26 ` Geert Uytterhoeven 2025-04-30 9:12 ` Tommaso Merciai @ 2025-06-18 10:10 ` Laurent Pinchart 2 siblings, 0 replies; 9+ messages in thread From: Laurent Pinchart @ 2025-06-18 10:10 UTC (permalink / raw) To: Prabhakar Cc: Mauro Carvalho Chehab, Hans Verkuil, linux-media, linux-kernel, linux-renesas-soc, Biju Das, Fabrizio Castro, Tommaso Merciai, Lad Prabhakar Hi Prabhakar, Thank you for the patch. On Tue, Apr 29, 2025 at 10:16:09AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Correct the misnamed FIFO-empty helper for the RZ/G3E CRU. Rename > `rz3e_fifo_empty` to `rzg3e_fifo_empty` to match the intended > naming convention. > > Reported-by: Biju Das <biju.das.jz@bp.renesas.com> > Closes: https://lore.kernel.org/all/TY3PR01MB11346E57A3DF8D8A90A405E4686812@TY3PR01MB11346.jpnprd01.prod.outlook.com/ > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 2 +- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 +- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > index 5fa73ab2db53..db27819d8200 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c > @@ -366,7 +366,7 @@ static const struct rzg2l_cru_info rzg3e_cru_info = { > .irq_handler = rzg3e_cru_irq, > .enable_interrupts = rzg3e_cru_enable_interrupts, > .disable_interrupts = rzg3e_cru_disable_interrupts, > - .fifo_empty = rz3e_fifo_empty, > + .fifo_empty = rzg3e_fifo_empty, > .csi_setup = rzg3e_cru_csi2_setup, > }; > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > index c30f3b281284..56feda6e6207 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h > @@ -199,7 +199,7 @@ void rzg3e_cru_enable_interrupts(struct rzg2l_cru_dev *cru); > void rzg3e_cru_disable_interrupts(struct rzg2l_cru_dev *cru); > > bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru); > -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru); > +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru); > void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, > const struct rzg2l_cru_ip_format *ip_fmt, > u8 csi_vc); > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 3d0810b3c35e..ab35caf97c51 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -323,7 +323,7 @@ static int rzg2l_cru_initialize_image_conv(struct rzg2l_cru_dev *cru, > return 0; > } > > -bool rz3e_fifo_empty(struct rzg2l_cru_dev *cru) > +bool rzg3e_fifo_empty(struct rzg2l_cru_dev *cru) > { > u32 amnfifopntr = rzg2l_cru_read(cru, AMnFIFOPNTR); > -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-06-18 10:10 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-04-29 9:16 [PATCH v2 0/2] media: renesas: rzg2l-cru: Fix FIFO empty check and typo Prabhakar 2025-04-29 9:16 ` [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty check Prabhakar 2025-04-29 14:24 ` Geert Uytterhoeven 2025-04-30 9:11 ` Tommaso Merciai 2025-06-18 10:09 ` Laurent Pinchart 2025-04-29 9:16 ` [PATCH v2 2/2] media: renesas: rzg2l-cru: Fix typo in rzg3e_fifo_empty name Prabhakar 2025-04-29 14:26 ` Geert Uytterhoeven 2025-04-30 9:12 ` Tommaso Merciai 2025-06-18 10:10 ` Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox