From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 947C2257458 for ; Mon, 16 Jun 2025 15:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750087965; cv=none; b=WBb+0s2uDTNUfE7+4leqVpnut3ikw/7f6KOxFTg5fXYWP2T71rhbA+EBX7MGfAHA0r4uhMoFMPmap+wOjTp64yB/DAM0FjAxn8Jb/iN3b9NNxsqMvB/CTB9xY8+lcPc93EXUik0E3oTo0PqB/FlhQvNKyhNZunY8783vKRN68r0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750087965; c=relaxed/simple; bh=kr3wYg3rZXyGtV3UoD64twSnhAcaIs6q1DS0t2r5w+M=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lZ71sXolwgqHiRVV+5ChCUyWZ2ZELlvT7+wc6Z0Llk+cJ6dOvXfikgsx0hsWI4UredDBXKcU27SJolWx6xUDKvOK9CT6Hzt6gi8ATg2+QWoPlOz7bkipFQwrg6ABD9exVOpcmQNWeO54mDft0n3itOfY2P/Nlrfquwx5W38Kj8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Yy9vEqu+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Yy9vEqu+" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55G8Rd0k011453 for ; Mon, 16 Jun 2025 15:32:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=MjWkI4SFpcOt65w9qps1mH2t kuW75zlaOjXPIX+Ab8g=; b=Yy9vEqu+A+7G/i/1z7equHhRho8KdNStsk62HkXQ fultMqHPiPlimkrWYUS4NVhmK1/Yw8Ax3Y3GcmjzROha4rRajy3LTUO/Ldqg99rX BNUPx1kGK/wUThCIRfpY10aLJsBkpRBc+cHGLYRSXgqB1LaXRnGXhr5unvoQaMPn dHlCfv4kSaUKeq/VECBi8IVS3hxA/AMzOKSmQYbsRbXo6H1aFXYRv7VPUSeLtaHj CkRFnJ3qZ+ui70mE3idLreIW4cFJ11nY7pPF3Bg447IWYTlQuibs66OUdRPOW6u0 ztbd9vLCV+MrjwSFioCwaXj1Y8EEgVR9XVInwgKj0jyLyQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 479qp5kmx9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 16 Jun 2025 15:32:42 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4a441a769c7so91585411cf.3 for ; Mon, 16 Jun 2025 08:32:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750087961; x=1750692761; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MjWkI4SFpcOt65w9qps1mH2tkuW75zlaOjXPIX+Ab8g=; b=IOdWKxN8rjJEqBeANkxPN0x8Y2NCYDhEz+CrUSwgTcH0Cf5ZUR8n9+1FQOPaaruy/U vgO+aiERwPW168SuB14GSiIiyRyj+Sq24nweRGkMAgOxZYXuicBtv1FI3G3lC4cVTGR5 JISQXbumO6FOQ+BBMu6LOmnf2xPWUTGvNbZpYNKkpa4pjktG+0HtTlLo2nSxCncrNb/L RvDdE7FfNSTAW3UgSuwANv/b5ur/58oTXZhYXBxxGJ+cmu5loD9jZM7SAv5qSnudjDk9 Ky4yFM7almTrerfsYzKpCLyDRqptA8pPrQSEm/27wkjXSSwusf5XGr4utVIY/7ZWnDr4 NyuA== X-Forwarded-Encrypted: i=1; AJvYcCV8yLwyu8OA7ZkG0RrVIL3qPf1WZSjL5+1qJU3sdH3OgoFBLMDaiDbuH31oTwjf25Lf2OehjBRHfgBwww==@vger.kernel.org X-Gm-Message-State: AOJu0YzDXM+GIWZ69JZ7o3ZGmLKDH+XrFfe50wwgVJV5pGI1jP2yuyxZ VL0P3uOYEPcTeMcextBCWzgWn761i1+oKS8KxTOFTtoDky6sH2kVO5dYag000odrK4hSYOEEaG7 uICw7WR9hBQRuPB0WGJQh/IlcL6Vla/eVrbwDT2zAbgHAsCyUpIG/3yT7/RFIw1e4xA== X-Gm-Gg: ASbGncu4jV1HjWM+brGAQuTLvrBfaI9aoIBhpjsvIfOk7ywfPOIGM2sW4OR077JBlCL nXMg0XKknwQSwEXMZbHc6jMJaSoV8+dit3qntXfEfY/BrZ5Tn5jZ9OCZX3qjy+tsRdtgUNQpLrR bvQtU3gjG1Vuv+46wiouS5zAYMmQ1LbCyr0WkjovPd4lVF9nhsDEE9lLevU3J3p34PoaFgT+120 t0hqf2/AcpC7AmckFLJr1WVbmFaxGoab381/oPCVybPcbGII59A//zHfHmTO45hkEqEWZWk1bTB tu/samd4W2cV//crbIFDI+DPrLxZXlCNvj1EGqzOQXtqUj9EZ1DPD4eKNw== X-Received: by 2002:a05:622a:1389:b0:494:b377:a77b with SMTP id d75a77b69052e-4a73c588d3cmr159812961cf.27.1750087961068; Mon, 16 Jun 2025 08:32:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+R0hwCRZSDz8dr59ev73SqBlCbBIcfKtSFASTz3f8rP6S1y9RE9rYy2jqtrzZS+XPKB9+SA== X-Received: by 2002:a05:622a:1389:b0:494:b377:a77b with SMTP id d75a77b69052e-4a73c588d3cmr159812081cf.27.1750087960386; Mon, 16 Jun 2025 08:32:40 -0700 (PDT) Received: from trex (132.red-79-144-190.dynamicip.rima-tde.net. [79.144.190.132]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532061c49fsm126142765e9.1.2025.06.16.08.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 08:32:39 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Mon, 16 Jun 2025 17:32:38 +0200 To: Vikash Garodia Cc: Jorge Ramirez , quic_dikshita@quicinc.com, bryan.odonoghue@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, hans.verkuil@cisco.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: venus: hfi: explicitly release IRQ during teardown Message-ID: References: <20250612082943.2753676-1-jorge.ramirez@oss.qualcomm.com> <54157ce5-8a6b-75ae-0a21-a8df59242c40@quicinc.com> <1bdf289b-5eec-d5de-a08b-6c7a772e15a3@quicinc.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1bdf289b-5eec-d5de-a08b-6c7a772e15a3@quicinc.com> X-Proofpoint-GUID: CH34-wgn5K45ynIns1WejxeBqPDywNrv X-Proofpoint-ORIG-GUID: CH34-wgn5K45ynIns1WejxeBqPDywNrv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDEwMCBTYWx0ZWRfX9TSt13488GtE xGiuakeWJ2aVUozI7+iGHpW3Jaq/d1U8TLBvWgsErmAqprSn3tFf5zx0EeHQ28FYpzqG5QoTn4P 3VVXaVFEZ0W32eLQy2W8t1ulivuX5hPzo+gllZq6bpcF2tgbuLYthtaEywtvG2h0V0VqnQCkeBf gTpV4BSuO2budic3hdoghjFsPzP+CvQw9eNd5ncTEkzRfwyBHeci/1k9BfWjoEZyQ9eD6fe8E1S iKZlTTbhey6+4lkdQWrn5t1q/MKRsTp+8bS86dBy04Ywaw0KhsdpCJgOrQZXv+XUb5sNqcIumXT v/h8cFy2wjcVgKJA+BEhLVg4rRtoFMq1wQRLmVaxqu04idchfQvGwS9jCptoXMfNpZASgUVmNkF nzRjwHm3UeQpxovq2TrgnANE90GRP49sAO2hg3kDELu9eYZP448zZUUkzZAVZLusgcPRaXkT X-Authority-Analysis: v=2.4 cv=fMc53Yae c=1 sm=1 tr=0 ts=6850391a cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=wjE3nLva0YkvARyJ+Gfmxg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=5inwfkmlzAndmB7UmJYA:9 a=CjuIK1q_8ugA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_07,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 mlxlogscore=959 spamscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506160100 On 16/06/25 20:14:36, Vikash Garodia wrote: > Hi Jorge, > > On 6/16/2025 6:29 PM, Jorge Ramirez wrote: > > On 16/06/25 17:26:24, Vikash Garodia wrote: > >> > >> On 6/12/2025 1:59 PM, Jorge Ramirez-Ortiz wrote: > >>> Ensure the IRQ is released before dismantling the ISR handler and > >>> clearing related pointers. > >>> > >>> This prevents any possibility of the interrupt triggering after the > >>> handler context has been invalidated. > >>> > >>> Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files") > >>> Signed-off-by: Jorge Ramirez-Ortiz > >>> --- > >>> drivers/media/platform/qcom/venus/hfi_venus.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c > >>> index b5f2ea879950..d9d62d965bcf 100644 > >>> --- a/drivers/media/platform/qcom/venus/hfi_venus.c > >>> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c > >>> @@ -1678,6 +1678,7 @@ void venus_hfi_destroy(struct venus_core *core) > >>> venus_interface_queues_release(hdev); > >>> mutex_destroy(&hdev->lock); > >>> kfree(hdev); > >>> + devm_free_irq(core->dev, core->irq, core); > >> Could you please check and add the handling here [1] as well ? > >> > >> [1] > >> https://elixir.bootlin.com/linux/v6.16-rc1/source/drivers/media/platform/qcom/venus/core.c#L427 > > > > hi Vikash, sorry I dont get your point - what do you mean? > IRQ need to be freed even for error cases during venus_probe(). > but this is what the current patch does (venus_hfi_destroy is called at the end of probe error handling as well). > Regards, > Vikash > > > >> > >> Regards, > >> Vikash > >>> core->ops = NULL; > >>> } > >>>