From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12310292B33 for ; Mon, 16 Jun 2025 12:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750078653; cv=none; b=QcWhXYCY3+jR6wso9ZKvGy1vkZsMYTOK8pa/o13eN5xCbZV19dCzmPzHCvNmqZOkWizB9wCvd2prS1s53BfmetPQ1RWW/0/OgSrgEk6kd9ko0q5FFNGbxnwokJwiRFdNVWzf/wWNcE+PEl9h7ZSNPHLujpkvDyNxDVmawpXUN24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750078653; c=relaxed/simple; bh=+7ZvudxHU1Lit+zQphHI1ArwnPJbfdXOQbD3tJTkJx8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tnvvl1JSNl6qSBozN6U4vfSRNW5HMzIM4LDNMbQza0N4o4UxVE1mIxXsbv4Cqmo55dNdSc1YHi+CirqWdggRJe52IX/yoqHUMRt1ep6FlY46egIdAmgcO8z/GMAZhLPYqymDvq0CAikJu5ClEVBhRAuo3dCLbcDCoL0YaKN/TQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WcqeOPWc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WcqeOPWc" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55G8uKiv032348 for ; Mon, 16 Jun 2025 12:57:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Z64Ls8klGzhod1haDtExsW6H yVPHV51JzdXZy1TafjE=; b=WcqeOPWcceP32j0mgY/yv5a28y/XMM+SThZ+QBmk +l/787gLGvRQOP9ZKwLG0amzlIaa4BV5rBrfePyoFOFJHdjDB2LQZqGEX098R8EI JGk1556vWLDOwhlC/Y8yKSqHNXWThT5Onr055PMzaBfIW6H9IKjAcDdnhL+StnFh wZn19+880KTMg5TpVnUYTwH51NteuNSskWHDsG8InTWQcyaKPJ6SiReXX4lcPIMQ QLyWy9jCyQNdkYRQee3KgUttamaH61uc3uUWGnG7GNX9f4i58uAoeqMXT2L7OYvf auiUH2Z9drrkCE+Pugv+mTmMUB1uWgPuc07RpaX+Io6RAA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4791hfck0v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 16 Jun 2025 12:57:31 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7d3901ff832so966842185a.3 for ; Mon, 16 Jun 2025 05:57:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750078650; x=1750683450; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z64Ls8klGzhod1haDtExsW6HyVPHV51JzdXZy1TafjE=; b=rlROo3JDOZMjl8RvyWV6SvOiUDrQ4ZvgcoIrSMZxoIDGOV1+etpsVtlxO+cblNNntX +USvMfqfCmexOTQUghxBwObxdVwVrojVsl8095YGe0H2wSWxGW6BGUWl280B8OO5iwBY 6/hZ01sGjjZe0p5Ccf0zq/RNsF7LiGSWmU6ZAGRdGdav8kZUsV8aBLTLGwbR4DU+tEWQ df9mBfviBGrxg4axJDXn4b42kshoV1oGJ90W2sXmFC/xHma10KwjSk5QQ78ZvcztVNhE KyaPePQIuFjbpRB/0krc2cbwd1pCUOGVk/uDwmKNkquqedxknPo8KOBBHK/QoyaJ8pIE PF4w== X-Forwarded-Encrypted: i=1; AJvYcCXQrPFuvR/bL4HekUNWZjRxOG1aOSV2yr4QSKIJ1Yu4nEp7kLa1AN/ksvdzklx8YpCkBO6PTGusELMtag==@vger.kernel.org X-Gm-Message-State: AOJu0YwOnTxEiKl/iFgG/9szrOD+oKtl+XTjslM7F7NA/gmPa2F6QtuZ 6SEZejFNLwDF3TF514KNmrwwIhR/hyWM9BaLRCsW6WLniw6yiMn8wOn0wyd5+iJH5EQhMwwSMy+ 1hVhWas9Sj6LgtxMoPDUhaK8ZzFrboY76HI+4GfbkglqqlXUOW9rTtOHOiknSxKR+CA== X-Gm-Gg: ASbGncuDRw7UiUSjbYZ/8/A0cR90lxEj53Dv+QcQjHZ9Rf3fao/OKu/p5n1Mn9s8CDV 41/oUDlwLpdzYUuqMyL2Xz+E6/ZfUCVVdRQkq3O/fZmlo2fBx38eom05qCYB6Vx4czYAHSE9tQM B5HjBZwRjB/PHAIwlT4aTUVzV6yonkRpaoPvR4zLcwvgq0LbSquGHqKLeJLrXhSiQd1j/x0BHXQ t6VjqACpz8Nvr5Jl303MQ7QkO9jFq7XyCXiYGS2LOV7WfS6H523l9vZE2tQ36SSp1Y8pBTAayYp U6xmqme9c6d2eiUqMpyrpQyvcAKqaP8w26VHIbPn/0PfT1agUdfF0ER7QA== X-Received: by 2002:a05:620a:1a8b:b0:7cd:ca60:7bdc with SMTP id af79cd13be357-7d3c6cfe10bmr1657082285a.48.1750078649660; Mon, 16 Jun 2025 05:57:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgXpyrNuCMRpJdFdvIc90NA0VcDu34jwTkut8k7XZoDWbnfYZHiho67s0sox/Pmk/OdelNRw== X-Received: by 2002:a05:620a:1a8b:b0:7cd:ca60:7bdc with SMTP id af79cd13be357-7d3c6cfe10bmr1657077785a.48.1750078649195; Mon, 16 Jun 2025 05:57:29 -0700 (PDT) Received: from trex (132.red-79-144-190.dynamicip.rima-tde.net. [79.144.190.132]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a54e71sm10879843f8f.1.2025.06.16.05.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 05:57:28 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Mon, 16 Jun 2025 14:57:27 +0200 To: Krzysztof Kozlowski Cc: Jorge Ramirez-Ortiz , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, stanimir.varbanov@linaro.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] arch: arm64: dts: qcom: qcm2290: Add venus video node Message-ID: References: <20250613140402.3619465-1-jorge.ramirez@oss.qualcomm.com> <20250613140402.3619465-3-jorge.ramirez@oss.qualcomm.com> <9e901aba-5e4b-40d8-810c-a7322637752f@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e901aba-5e4b-40d8-810c-a7322637752f@kernel.org> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDA4MSBTYWx0ZWRfX3gNE78qO+3Ju NWfbGNqDCT6r9bEeF0lZeIkDz4AiZwBkXt9qjSWcolp+wMvrbcxV9Vlj2QE1Q/PWa+98yG7Yp65 7q4Y7V9S5Gqp81gD8j2cgCxpckByj3Yf7n7HahD4xfpVqMcDN9yVMsjbDKD5Jn+nVDKFU4SpDGO w4wtkyOYlAuH3QXcB2dc145GXYwV15MrMV6u/rdfnpqkSnOFtkRTEhdLInTBUnbRMB+5HNbNFwb NCweQLfugm+wMApysBosB+0lKefsiNaUc1yHG6jTC6JAPMDor1+RdXBsOvi2gD5okkDVVrLhEAc F9caIlIhtKUiSnvQIZSJ0KSIdMoUvIe7N2XpMEpR4Qu07AdgQYm22qmT1rmNdlCLhazD8DZyjfC t/fp5IstLF6NLaExLlIcKKb+FC71DOPTp86w/Q3MAr+SbKgaMlqipdXhUlw6asErv6Ptgsnp X-Authority-Analysis: v=2.4 cv=VvEjA/2n c=1 sm=1 tr=0 ts=685014bb cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=wjE3nLva0YkvARyJ+Gfmxg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=Llyb1ICWO3Llu68erG4A:9 a=CjuIK1q_8ugA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: 1vOhva-g84D_VPHcYXWhmH4TEZ5-375G X-Proofpoint-ORIG-GUID: 1vOhva-g84D_VPHcYXWhmH4TEZ5-375G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_05,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 impostorscore=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506160081 On 16/06/25 10:22:06, Krzysztof Kozlowski wrote: > On 13/06/2025 16:03, Jorge Ramirez-Ortiz wrote: > > Add DT entries for the qcm2290 venus encoder/decoder. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 53 +++++++++++++++++++++++++++ > > DTS cannot be a dependency for driver. Order your patches correctly (see > dts coding style, soc maintainer rules or internal guidelines). > > > 1 file changed, 53 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > > index f49ac1c1f8a3..af2c1f66fe07 100644 > > --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi > > +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > > @@ -1628,6 +1628,59 @@ adreno_smmu: iommu@59a0000 { > > #iommu-cells = <2>; > > }; > > > > + venus: video-codec@5a00000 { > > + compatible = "qcom,qcm2290-venus"; > > + reg = <0 0x5a00000 0 0xff000>; > > + interrupts = ; > > + > > + power-domains = <&gcc GCC_VENUS_GDSC>, > > + <&gcc GCC_VCODEC0_GDSC>, > > + <&rpmpd QCM2290_VDDCX>; > > + power-domain-names = "venus", "vcodec0", "cx"; > > + operating-points-v2 = <&venus_opp_table>; > > + > > + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, > > + <&gcc GCC_VIDEO_AHB_CLK>, > > + <&gcc GCC_VENUS_CTL_AXI_CLK>, > > + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, > > + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, > > + <&gcc GCC_VCODEC0_AXI_CLK>; > > + clock-names = "core", "iface", "bus", "throttle", > > + "vcodec0_core", "vcodec0_bus"; > > + > > + memory-region = <&pil_video_mem>; > > + iommus = <&apps_smmu 0x860 0x0>, > > + <&apps_smmu 0x880 0x0>, > > + <&apps_smmu 0x861 0x04>, > > + <&apps_smmu 0x863 0x0>, > > + <&apps_smmu 0x804 0xE0>; > > + > > + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>, > > + <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>; > > + interconnect-names = "video-mem", "cpu-cfg"; > > + > > + venus_opp_table: opp-table { > > + compatible = "operating-points-v2"; > > + opp-133000000 { > > + opp-hz = /bits/ 64 <133000000>; > > + required-opps = <&rpmpd_opp_low_svs>; > > + }; > > + > > + opp-240000000 { > > + opp-hz = /bits/ 64 <240000000>; > > + required-opps = <&rpmpd_opp_svs>; > > + }; > > + }; > > + > > + video-decoder { > > + compatible = "venus-decoder"; > > Don't add deprecated properties. right - Bryan mentioned. my bad. > > Best regards, > Krzysztof