Re: [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema

Jorge Ramirez
2025-06-16T16:18:25Z

On 16/06/25 16:41:44, Krzysztof Kozlowski wrote:
> On 16/06/2025 14:52, Jorge Ramirez wrote:
> >>
> >>> + The Venus AR50_LITE IP is a video encode and decode accelerator present
> >>> + on Qualcomm platforms
> >>> +
> >>> +allOf:
> >>> + - $ref: qcom,venus-common.yaml#
> >>> +
> >>> +properties:
> >>> + compatible:
> >>> + const: qcom,qcm2290-venus
> >>> +
> >>> + power-domains:
> >>> + minItems: 2
> >>> + maxItems: 3
> >>> +
> >>> + power-domain-names:
> >>> + minItems: 2
> >>
> >> Why is this flexible? Either you have two or three. Not mixed.
> >
> > please check 5b380f242f360256c96e96adabeb7ce9ec784306
>
> This does not explain why this is optional HERE. You cannot use for a
> new platform an argument that some existing platform was changed in
> ABI-preserving way.

thanks for quick the follow up.

but bear with me please because I dont follow - why can the same logic
be used - it being applicable - and therefore result in a definition
similar to those other platforms?

how would I capture such a requirement if not as done in this patch?

>
> BTW, also subject prefixes needs fixing. For DTS: it is never "arch".

right, that is for patch 2 but ok, will fix there.

> For this patch: wrong order (see DT submitting patches).

yep, that is addressed in the next series

TIA!

>
> Best regards,
> Krzysztof