Re: [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema

Krzysztof Kozlowski
2025-06-16T16:23:23Z

On 16/06/2025 18:18, Jorge Ramirez wrote:
> On 16/06/25 16:41:44, Krzysztof Kozlowski wrote:
>> On 16/06/2025 14:52, Jorge Ramirez wrote:
>>>>
>>>>> + The Venus AR50_LITE IP is a video encode and decode accelerator present
>>>>> + on Qualcomm platforms
>>>>> +
>>>>> +allOf:
>>>>> + - $ref: qcom,venus-common.yaml#
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + const: qcom,qcm2290-venus
>>>>> +
>>>>> + power-domains:
>>>>> + minItems: 2
>>>>> + maxItems: 3
>>>>> +
>>>>> + power-domain-names:
>>>>> + minItems: 2
>>>>
>>>> Why is this flexible? Either you have two or three. Not mixed.
>>>
>>> please check 5b380f242f360256c96e96adabeb7ce9ec784306
>>
>> This does not explain why this is optional HERE. You cannot use for a
>> new platform an argument that some existing platform was changed in
>> ABI-preserving way.
>
> thanks for quick the follow up.
>
> but bear with me please because I dont follow - why can the same logic
> be used - it being applicable - and therefore result in a definition
> similar to those other platforms?

Because this platform either has 2 or 3, not both. Unless that's not
true, but then please share some arguments.

Best regards,
Krzysztof