linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Scally <dan.scally@ideasonboard.com>,
	<linux-media@vger.kernel.org>
Cc: <oe-kbuild-all@lists.linux.dev>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Daniel Scally <dan.scally@ideasonboard.com>
Subject: Re: [PATCH 2/4] media: mc: entity: Embed entity iterator in pipeline
Date: Wed, 9 Jul 2025 09:07:03 +0800	[thread overview]
Message-ID: <aG3At0Z78JR6diVQ@rli9-mobl> (raw)
In-Reply-To: <20250702-pipelines-v1-2-34525973e773@ideasonboard.com>

[-- Attachment #1: Type: text/plain, Size: 6295 bytes --]

Hi Daniel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on c0b1da281d84d33281fc49289f0c7f8aada450ff]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Scally/media-mc-entity-Move-media-pipeline-entity-iteration-functions/20250702-231706
base:   c0b1da281d84d33281fc49289f0c7f8aada450ff
patch link:    https://lore.kernel.org/r/20250702-pipelines-v1-2-34525973e773%40ideasonboard.com
patch subject: [PATCH 2/4] media: mc: entity: Embed entity iterator in pipeline
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: arc-allmodconfig (attached as .config)
compiler: arc-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (attached as reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507090728.WgTCOat0-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/platform/ti/omap3isp/ispvideo.c: In function 'isp_video_get_graph_data':
>> drivers/media/platform/ti/omap3isp/ispvideo.c:226:13: warning: unused variable 'ret' [-Wunused-variable]
     226 |         int ret;
         |             ^~~


vim +/ret +226 drivers/media/platform/ti/omap3isp/ispvideo.c

ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  219  
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  220  /* Return a pointer to the ISP video instance at the far end of the pipeline. */
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  221  static int isp_video_get_graph_data(struct isp_video *video,
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  222  				    struct isp_pipeline *pipe)
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  223  {
3e8537b4c15172 drivers/media/platform/ti/omap3isp/ispvideo.c Laurent Pinchart 2022-12-21  224  	struct media_entity *entity;
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  225  	struct isp_video *far_end = NULL;
28461451c0fc94 drivers/media/platform/omap3isp/ispvideo.c    Sakari Ailus     2015-12-16 @226  	int ret;
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  227  
4f5c32570d372e drivers/media/platform/ti/omap3isp/ispvideo.c Daniel Scally    2025-07-02  228  	media_pipeline_for_each_entity(&pipe->pipe, entity) {
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  229  		struct isp_video *__video;
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  230  
17d3d4058a6132 drivers/media/platform/omap3isp/ispvideo.c    Sakari Ailus     2015-12-16  231  		media_entity_enum_set(&pipe->ent_enum, entity);
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  232  
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  233  		if (far_end != NULL)
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  234  			continue;
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  235  
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  236  		if (entity == &video->video.entity)
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  237  			continue;
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  238  
45b46879a78567 drivers/media/platform/omap3isp/ispvideo.c    Laurent Pinchart 2016-02-29  239  		if (!is_media_entity_v4l2_video_device(entity))
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  240  			continue;
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  241  
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  242  		__video = to_isp_video(media_entity_to_video_device(entity));
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  243  		if (__video->type != video->type)
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  244  			far_end = __video;
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  245  	}
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  246  
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  247  	if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  248  		pipe->input = far_end;
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  249  		pipe->output = video;
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  250  	} else {
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  251  		if (far_end == NULL)
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  252  			return -EPIPE;
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  253  
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  254  		pipe->input = video;
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  255  		pipe->output = far_end;
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  256  	}
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  257  
ae5df813314a58 drivers/media/video/omap3isp/ispvideo.c       Sakari Ailus     2012-03-05  258  	return 0;
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  259  }
ad614acb7eca42 drivers/media/video/omap3isp/ispvideo.c       Laurent Pinchart 2011-02-12  260  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 80792 bytes --]

[-- Attachment #3: reproduce --]
[-- Type: text/plain, Size: 609 bytes --]

reproduce (this is a W=1 build):
        git clone https://github.com/intel/lkp-tests.git ~/lkp-tests
        git checkout c0b1da281d84d33281fc49289f0c7f8aada450ff
        b4 shazam https://lore.kernel.org/r/20250702-pipelines-v1-2-34525973e773@ideasonboard.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-15.1.0 ~/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-15.1.0 ~/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

  parent reply	other threads:[~2025-07-09  1:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 15:15 [PATCH 0/4] Helpers to manage starting / stopping multi-driver media pipelines Daniel Scally
2025-07-02 15:15 ` [PATCH 1/4] media: mc: entity: Move media pipeline entity iteration functions Daniel Scally
2025-07-02 15:15 ` [PATCH 2/4] media: mc: entity: Embed entity iterator in pipeline Daniel Scally
2025-07-02 20:05   ` Laurent Pinchart
2025-07-04  9:13     ` Dan Scally
2025-07-09  1:07   ` kernel test robot [this message]
2025-07-02 15:15 ` [PATCH 3/4] media: mc: entity: Add pipeline_started/stopped ops Daniel Scally
2025-07-02 20:08   ` Laurent Pinchart
2025-07-03  6:34     ` Dan Scally
2025-07-02 15:15 ` [PATCH 4/4] media: v4l2-dev: Add helpers to run media_pipeline_[started|stopped]() Daniel Scally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aG3At0Z78JR6diVQ@rli9-mobl \
    --to=lkp@intel.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).