From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: mchehab@kernel.org, michal.simek@amd.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: of xvip_enum_frame_size and xvip_get_format_by_code
Date: Sun, 13 Jul 2025 23:23:37 +0000 [thread overview]
Message-ID: <aHQ_-TCl02_mcHHz@gallifrey> (raw)
In-Reply-To: <20250713230109.GA10401@pendragon.ideasonboard.com>
* Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote:
> On Sun, Jul 13, 2025 at 04:51:08PM +0000, Dr. David Alan Gilbert wrote:
> > Hi,
> > I noticed in xilinx-cip.c there's xvip_enum_frame_size()
> > which was added back in 2013 but seems unused in tree, however
> > I had a dig and I found
> > https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841638/Xilinx+V4L2+TPG+driver
> > has a commit:
> > https://github.com/Xilinx/linux-xlnx/commit/1c113b4aef14004152fefc0e8b8dbbcc2314566f#diff-bb594682a92148570df8826933cf8629
> > from 2014 that uses it - but it looks like that commit never went
> > anywhere.
> >
> > So is xvip_enum_frame_size() or not?
> > I also see xvip_get_format_by_code() looks unused, but I don't
> > see any uses of it, even digging in that wiki.
>
> Those functions seem to have never been used in the mainline kernel.
> They were likely added to support drivers that have not been upstreamed.
Ah, shame.
> Both functions are used in the Xilinx BSP kernel.
OK, I'll stay clear.
Dave
> --
> Regards,
>
> Laurent Pinchart
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2025-07-13 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-13 16:51 of xvip_enum_frame_size and xvip_get_format_by_code Dr. David Alan Gilbert
2025-07-13 23:01 ` Laurent Pinchart
2025-07-13 23:23 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHQ_-TCl02_mcHHz@gallifrey \
--to=linux@treblig.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox