linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: atomisp: style fix for trailing statements
@ 2025-07-14 13:36 Timo Röhling
  2025-07-15  7:52 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Timo Röhling @ 2025-07-14 13:36 UTC (permalink / raw)
  To: linux-staging, linux-media, linux-kernel, Greg Kroah-Hartman,
	Sakari Ailus, Mauro Carvalho Chehab, Hans de Goede,
	Andy Shevchenko
  Cc: ~lkcamp/patches, koike, Timo Röhling

Fix checkpatch errors "ERROR: trailing statements should be on next line"
in drivers/staging/media/atomisp/pci/sh_css_params.c

Signed-off-by: Timo Röhling <roehling@debian.org>
---
 drivers/staging/media/atomisp/pci/sh_css_params.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
index 0d4a936ad80f..2eeb75653392 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_params.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
@@ -875,7 +875,8 @@ ia_css_process_kernel(struct ia_css_stream *stream,
 
 		/* update the other buffers to the pipe specific copies */
 		for (stage = pipeline->stages; stage; stage = stage->next) {
-			if (!stage || !stage->binary) continue;
+			if (!stage || !stage->binary)
+				continue;
 			process(pipeline->pipe_id, stage, params);
 		}
 	}
@@ -3045,7 +3046,8 @@ process_kernel_parameters(unsigned int pipe_id,
 	/* Call parameter process functions for all kernels */
 	/* Skip SC, since that is called on a temp sc table */
 	for (param_id = 0; param_id < IA_CSS_NUM_PARAMETER_IDS; param_id++) {
-		if (param_id == IA_CSS_SC_ID) continue;
+		if (param_id == IA_CSS_SC_ID)
+			continue;
 		if (params->config_changed[param_id])
 			ia_css_kernel_process_param[param_id](pipe_id, stage, params);
 	}
@@ -3600,7 +3602,8 @@ sh_css_params_write_to_ddr_internal(
 						    IA_CSS_PARAM_CLASS_PARAM, mem);
 		size_t size = isp_data->size;
 
-		if (!size) continue;
+		if (!size)
+			continue;
 		buff_realloced = reallocate_buffer(&ddr_map->isp_mem_param[stage_num][mem],
 						&ddr_map_size->isp_mem_param[stage_num][mem],
 						size,
-- 
2.50.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: atomisp: style fix for trailing statements
  2025-07-14 13:36 [PATCH] media: atomisp: style fix for trailing statements Timo Röhling
@ 2025-07-15  7:52 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-07-15  7:52 UTC (permalink / raw)
  To: Timo Röhling
  Cc: linux-staging, linux-media, linux-kernel, Greg Kroah-Hartman,
	Sakari Ailus, Mauro Carvalho Chehab, Hans de Goede,
	Andy Shevchenko, ~lkcamp/patches, koike

On Mon, Jul 14, 2025 at 03:36:54PM +0200, Timo Röhling wrote:
> Fix checkpatch errors "ERROR: trailing statements should be on next line"
> in drivers/staging/media/atomisp/pci/sh_css_params.c

With period added to the end of the above

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-15  7:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14 13:36 [PATCH] media: atomisp: style fix for trailing statements Timo Röhling
2025-07-15  7:52 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).