[PATCH] staging: atomisp: isp: fix open brace on new line

[PATCH] staging: atomisp: isp: fix open brace on new line

[Martin Weidenauer]

	Fix checkpatch error "ERROR: that open brace { should be on the previous line"
	in ia_css_dvs.host.c:277.

	Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>

	---

	Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!
---
 .../atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c      | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
index 30c84639d7e8..7fda12d3a646 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
@@ -274,8 +274,7 @@ store_dvs_6axis_config(
 					       binary,
 					       dvs_in_frame_info);
 
-	if (!me)
-	{
+	if (!me) {
 		IA_CSS_LEAVE_ERR_PRIVATE(-ENOMEM);
 		return -ENOMEM;
 	}
-- 
2.39.5

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Greg KH]

On Mon, Jul 14, 2025 at 03:19:53PM +0200, Martin Weidenauer wrote:
> 	Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> 	in ia_css_dvs.host.c:277.
> 
> 	Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>
> 
> 	---
> 
> 	Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!

Odd indentation, how did that happen?

thanks,

greg k-h

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Martin Weidenauer]

If you mean the indentation in the file, I think it's unfortunately just a messy driver in general.
I mean I could fix it in another commit in general if you want.

Be well,
Martin

On 14 July 2025 15:24:57 CEST, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Mon, Jul 14, 2025 at 03:19:53PM +0200, Martin Weidenauer wrote:
>> 	Fix checkpatch error "ERROR: that open brace { should be on the previous line"
>> 	in ia_css_dvs.host.c:277.
>> 
>> 	Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>
>> 
>> 	---
>> 
>> 	Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!
>
>Odd indentation, how did that happen?
>
>thanks,
>
>greg k-h

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 4:51 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
>
> If you mean the indentation in the file, I think it's unfortunately just a messy driver in general.
> I mean I could fix it in another commit in general if you want.

Do not top-post!

The question was about the patch that may not be applied due to wrong
indentation.

> On 14 July 2025 15:24:57 CEST, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Mon, Jul 14, 2025 at 03:19:53PM +0200, Martin Weidenauer wrote:
> >>      Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> >>      in ia_css_dvs.host.c:277.
> >>
> >>      Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>
> >>
> >>      ---
> >>
> >>      Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!
> >
> >Odd indentation, how did that happen?



-- 
With Best Regards,
Andy Shevchenko

[PATCH] staging: atomisp: isp: fix open brace on new line

[Martin Weidenauer]

Fix checkpatch error "ERROR: that open brace { should be on the previous line"
in ia_css_dvs.host.c:277.

Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>

---

Hi, I hope this should fix the indentation problems.

---
 .../atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c      | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
index 30c84639d7e8..7fda12d3a646 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
@@ -274,8 +274,7 @@ store_dvs_6axis_config(
 					       binary,
 					       dvs_in_frame_info);
 
-	if (!me)
-	{
+	if (!me) {
 		IA_CSS_LEAVE_ERR_PRIVATE(-ENOMEM);
 		return -ENOMEM;
 	}
-- 
2.39.5

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Andy Shevchenko]

Guys, please, coordinate and issue only one (or a few) patch(es) per
an issue. No need to send zillions patches for the same problem
file-by-file.

On Mon, Jul 14, 2025 at 6:34 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
>
> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> in ia_css_dvs.host.c:277.


--
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Martin Weidenauer]

On 14 July 2025 19:47:41 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>Guys, please, coordinate and issue only one (or a few) patch(es) per
>an issue. No need to send zillions patches for the same problem
>file-by-file.
>
>On Mon, Jul 14, 2025 at 6:34 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
>>
>> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
>> in ia_css_dvs.host.c:277.
>
>
>--
>With Best Regards,
>Andy Shevchenko

I deeply apologize, however this was the instruction of our workshop in DebConf by Helen Koike <koike@igalia.com>

Here is the link to the exact workshop:
<https://debconf25.debconf.org/talks/55-submit-your-first-contribution-to-the-linux-kernel/>

In grave apologies,
Martin

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 10:39 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> On 14 July 2025 19:47:41 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> >Guys, please, coordinate and issue only one (or a few) patch(es) per
> >an issue. No need to send zillions patches for the same problem
> >file-by-file.

> >On Mon, Jul 14, 2025 at 6:34 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> >>
> >> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> >> in ia_css_dvs.host.c:277.

> I deeply apologize, however this was the instruction of our workshop in DebConf by Helen Koike <koike@igalia.com>

This may be okay for the driver that consists of let's say less than
10 files, AtomISP consists of dozens of files in several (nested)
folders. It's not a good example for such an approach.

> Here is the link to the exact workshop:
> <https://debconf25.debconf.org/talks/55-submit-your-first-contribution-to-the-linux-kernel/>

Hmm... this really needs an update to explain how to work with the
drivers that contain many files and literally tens of thousands lines
of code.

In any case the problem with your contribution is not the code, the
absence of coordination and possibility to clash with somebody else.
Also it looks like a DDoS attack against maintainers capacity. The
smaller patches are and the more of them --- the less the usefulness
of all this activity as at some point that floods the maintainer's
mailbox.

TL:DR; (always) Use common sense!


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Martin Weidenauer]

On 14 July 2025 23:38:47 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>On Mon, Jul 14, 2025 at 10:39 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
>> On 14 July 2025 19:47:41 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
>> >Guys, please, coordinate and issue only one (or a few) patch(es) per
>> >an issue. No need to send zillions patches for the same problem
>> >file-by-file.
>
>> >On Mon, Jul 14, 2025 at 6:34 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
>> >>
>> >> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
>> >> in ia_css_dvs.host.c:277.
>
>> I deeply apologize, however this was the instruction of our workshop in DebConf by Helen Koike <koike@igalia.com>
>
>This may be okay for the driver that consists of let's say less than
>10 files, AtomISP consists of dozens of files in several (nested)
>folders. It's not a good example for such an approach.
>
>> Here is the link to the exact workshop:
>> <https://debconf25.debconf.org/talks/55-submit-your-first-contribution-to-the-linux-kernel/>
>
>Hmm... this really needs an update to explain how to work with the
>drivers that contain many files and literally tens of thousands lines
>of code.
>
>In any case the problem with your contribution is not the code, the
>absence of coordination and possibility to clash with somebody else.
>Also it looks like a DDoS attack against maintainers capacity. The
>smaller patches are and the more of them --- the less the usefulness
>of all this activity as at some point that floods the maintainer's
>mailbox.
>
>TL:DR; (always) Use common sense!
>
>

To be honest, such a contribution also seemed to me a bit useless but I thought all of this had been discussed with you maintainers beforehand.

As it seems this was not the case, although the workshop has shown us how easy it is to make contributions and for my part I will use the knowledge to make meaningful changes.
So you can scrap this commit and I'll make a few commits in the next days which make more sense.

I apologize again and it is an honor for me to start contributing to your driver.
Be well,
Martin

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Andy Shevchenko]

On Tue, Jul 15, 2025 at 12:54 AM Martin Weidenauer <martin@weidenauer.cc> wrote:
> On 14 July 2025 23:38:47 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> >On Mon, Jul 14, 2025 at 10:39 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> >> On 14 July 2025 19:47:41 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> >
> >> >Guys, please, coordinate and issue only one (or a few) patch(es) per
> >> >an issue. No need to send zillions patches for the same problem
> >> >file-by-file.
> >
> >> >On Mon, Jul 14, 2025 at 6:34 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> >> >>
> >> >> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> >> >> in ia_css_dvs.host.c:277.
> >
> >> I deeply apologize, however this was the instruction of our workshop in DebConf by Helen Koike <koike@igalia.com>
> >
> >This may be okay for the driver that consists of let's say less than
> >10 files, AtomISP consists of dozens of files in several (nested)
> >folders. It's not a good example for such an approach.
> >
> >> Here is the link to the exact workshop:
> >> <https://debconf25.debconf.org/talks/55-submit-your-first-contribution-to-the-linux-kernel/>
> >
> >Hmm... this really needs an update to explain how to work with the
> >drivers that contain many files and literally tens of thousands lines
> >of code.
> >
> >In any case the problem with your contribution is not the code, the
> >absence of coordination and possibility to clash with somebody else.
> >Also it looks like a DDoS attack against maintainers capacity. The
> >smaller patches are and the more of them --- the less the usefulness
> >of all this activity as at some point that floods the maintainer's
> >mailbox.
> >
> >TL:DR; (always) Use common sense!
>
> To be honest, such a contribution also seemed to me a bit useless but I thought all of this had been discussed with you maintainers beforehand.
>
> As it seems this was not the case, although the workshop has shown us how easy it is to make contributions and for my part I will use the knowledge to make meaningful changes.
> So you can scrap this commit and I'll make a few commits in the next days which make more sense.

The problem is not the code, the contribution is okay and appreciated.
The problem is that for _the same_ issue there are tons of patches
from _different_ people. Just discuss who does what and send "one
contributer == one issue" (under one issue, I mean class of the issues
checkpatch or other tools report, for instance, the "if (foo)
return;"-like which are on one line and needs to be two or more lines,
do _all_ of them by _a single_ contributor.


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Greg KH]

On Tue, Jul 15, 2025 at 09:57:19AM +0300, Andy Shevchenko wrote:
> On Tue, Jul 15, 2025 at 12:54 AM Martin Weidenauer <martin@weidenauer.cc> wrote:
> > On 14 July 2025 23:38:47 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > >On Mon, Jul 14, 2025 at 10:39 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> > >> On 14 July 2025 19:47:41 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > >
> > >> >Guys, please, coordinate and issue only one (or a few) patch(es) per
> > >> >an issue. No need to send zillions patches for the same problem
> > >> >file-by-file.
> > >
> > >> >On Mon, Jul 14, 2025 at 6:34 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> > >> >>
> > >> >> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> > >> >> in ia_css_dvs.host.c:277.
> > >
> > >> I deeply apologize, however this was the instruction of our workshop in DebConf by Helen Koike <koike@igalia.com>
> > >
> > >This may be okay for the driver that consists of let's say less than
> > >10 files, AtomISP consists of dozens of files in several (nested)
> > >folders. It's not a good example for such an approach.
> > >
> > >> Here is the link to the exact workshop:
> > >> <https://debconf25.debconf.org/talks/55-submit-your-first-contribution-to-the-linux-kernel/>
> > >
> > >Hmm... this really needs an update to explain how to work with the
> > >drivers that contain many files and literally tens of thousands lines
> > >of code.
> > >
> > >In any case the problem with your contribution is not the code, the
> > >absence of coordination and possibility to clash with somebody else.
> > >Also it looks like a DDoS attack against maintainers capacity. The
> > >smaller patches are and the more of them --- the less the usefulness
> > >of all this activity as at some point that floods the maintainer's
> > >mailbox.
> > >
> > >TL:DR; (always) Use common sense!
> >
> > To be honest, such a contribution also seemed to me a bit useless but I thought all of this had been discussed with you maintainers beforehand.
> >
> > As it seems this was not the case, although the workshop has shown us how easy it is to make contributions and for my part I will use the knowledge to make meaningful changes.
> > So you can scrap this commit and I'll make a few commits in the next days which make more sense.
> 
> The problem is not the code, the contribution is okay and appreciated.
> The problem is that for _the same_ issue there are tons of patches
> from _different_ people. Just discuss who does what and send "one
> contributer == one issue" (under one issue, I mean class of the issues
> checkpatch or other tools report, for instance, the "if (foo)
> return;"-like which are on one line and needs to be two or more lines,
> do _all_ of them by _a single_ contributor.

No, that's not necessary at all, really.  Just take them in the order
they come in and review/apply them as normal.  Don't expect people to
coordinate together, especially for staging stuff, that's crazy.

This is just part of staging, it's the maintainers job to help guide new
contributors like this.  If you don't want to do this, that's fine, just
delete these media drivers out of staging then.  And don't blame the
submitters, it's not their fault at all.

thanks,

greg k-h

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Andy Shevchenko]

On Tue, Jul 15, 2025 at 10:04 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Jul 15, 2025 at 09:57:19AM +0300, Andy Shevchenko wrote:
> > On Tue, Jul 15, 2025 at 12:54 AM Martin Weidenauer <martin@weidenauer.cc> wrote:
> > > On 14 July 2025 23:38:47 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > >On Mon, Jul 14, 2025 at 10:39 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> > > >> On 14 July 2025 19:47:41 CEST, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > >
> > > >> >Guys, please, coordinate and issue only one (or a few) patch(es) per
> > > >> >an issue. No need to send zillions patches for the same problem
> > > >> >file-by-file.
> > > >
> > > >> >On Mon, Jul 14, 2025 at 6:34 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
> > > >> >>
> > > >> >> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> > > >> >> in ia_css_dvs.host.c:277.
> > > >
> > > >> I deeply apologize, however this was the instruction of our workshop in DebConf by Helen Koike <koike@igalia.com>
> > > >
> > > >This may be okay for the driver that consists of let's say less than
> > > >10 files, AtomISP consists of dozens of files in several (nested)
> > > >folders. It's not a good example for such an approach.
> > > >
> > > >> Here is the link to the exact workshop:
> > > >> <https://debconf25.debconf.org/talks/55-submit-your-first-contribution-to-the-linux-kernel/>
> > > >
> > > >Hmm... this really needs an update to explain how to work with the
> > > >drivers that contain many files and literally tens of thousands lines
> > > >of code.
> > > >
> > > >In any case the problem with your contribution is not the code, the
> > > >absence of coordination and possibility to clash with somebody else.
> > > >Also it looks like a DDoS attack against maintainers capacity. The
> > > >smaller patches are and the more of them --- the less the usefulness
> > > >of all this activity as at some point that floods the maintainer's
> > > >mailbox.
> > > >
> > > >TL:DR; (always) Use common sense!
> > >
> > > To be honest, such a contribution also seemed to me a bit useless but I thought all of this had been discussed with you maintainers beforehand.
> > >
> > > As it seems this was not the case, although the workshop has shown us how easy it is to make contributions and for my part I will use the knowledge to make meaningful changes.
> > > So you can scrap this commit and I'll make a few commits in the next days which make more sense.
> >
> > The problem is not the code, the contribution is okay and appreciated.
> > The problem is that for _the same_ issue there are tons of patches
> > from _different_ people. Just discuss who does what and send "one
> > contributer == one issue" (under one issue, I mean class of the issues
> > checkpatch or other tools report, for instance, the "if (foo)
> > return;"-like which are on one line and needs to be two or more lines,
> > do _all_ of them by _a single_ contributor.
>
> No, that's not necessary at all, really.  Just take them in the order
> they come in and review/apply them as normal.  Don't expect people to
> coordinate together, especially for staging stuff, that's crazy.

It might become hard to review, when there are many patches with the
(almost the) same subject and same comment and the only difference is
the file that is fixed. But fine, we can survive for now.

> This is just part of staging, it's the maintainers job to help guide new
> contributors like this.  If you don't want to do this, that's fine, just
> delete these media drivers out of staging then.  And don't blame the
> submitters, it's not their fault at all.

It's not blaming, it's advice on how to make a flow easier to follow.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 05:34:09PM +0200, Martin Weidenauer wrote:
> Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> in ia_css_dvs.host.c:277.

...


> Hi, I hope this should fix the indentation problems.

Missed versioning and changelog, but otherwise okay.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko