[PATCH] media: c8sectpfe: fix probe device leaks

[PATCH] media: c8sectpfe: fix probe device leaks

[Johan Hovold]

Make sure to drop the references taken to the I2C adapters during probe
on probe failure (e.g. probe deferral) and on driver unbind.

Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support")
Cc: stable@vger.kernel.org	# 4.3
Cc: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 .../media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
index 89bd15a4d26a..3f94d9b4ef1e 100644
--- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
@@ -655,6 +655,13 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq, void *priv)
 	return IRQ_HANDLED;
 }
 
+static void c8sectpfe_put_device(void *_dev)
+{
+	struct device *dev = _dev;
+
+	put_device(dev);
+}
+
 static int c8sectpfe_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -799,6 +806,11 @@ static int c8sectpfe_probe(struct platform_device *pdev)
 			return -ENODEV;
 		}
 
+		ret = devm_add_action_or_reset(dev, c8sectpfe_put_device,
+					       &tsin->i2c_adapter->dev);
+		if (ret)
+			return ret;
+
 		/* Acquire reset GPIO and activate it */
 		tsin->rst_gpio = devm_fwnode_gpiod_get(dev,
 						       of_fwnode_handle(child),
-- 
2.49.1

Re: [PATCH] media: c8sectpfe: fix probe device leaks

[Johan Hovold]

On Tue, Sep 23, 2025 at 05:16:05PM +0200, Johan Hovold wrote:
> Make sure to drop the references taken to the I2C adapters during probe
> on probe failure (e.g. probe deferral) and on driver unbind.
> 
> Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support")
> Cc: stable@vger.kernel.org	# 4.3
> Cc: Peter Griffin <peter.griffin@linaro.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---

Can this one be picked up for 6.19?

Johan

Re: [PATCH] media: c8sectpfe: fix probe device leaks

[Patrice CHOTARD]

On 10/27/25 14:35, Johan Hovold wrote:
> On Tue, Sep 23, 2025 at 05:16:05PM +0200, Johan Hovold wrote:
>> Make sure to drop the references taken to the I2C adapters during probe
>> on probe failure (e.g. probe deferral) and on driver unbind.
>>
>> Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support")
>> Cc: stable@vger.kernel.org	# 4.3
>> Cc: Peter Griffin <peter.griffin@linaro.org>
>> Signed-off-by: Johan Hovold <johan@kernel.org>
>> ---
> 
> Can this one be picked up for 6.19?
> 
> Johan


Hi Johan

The removal of c8sectpfe driver has been initiated see https://lore.kernel.org/linux-media/c3a35ad6-c4f6-46ad-9b5b-1fe43385ecc5@foss.st.com/

Regards
Patrice

Re: [PATCH] media: c8sectpfe: fix probe device leaks

[Peter Griffin]

Hi folks,

On Mon, 27 Oct 2025 at 14:34, Patrice CHOTARD
<patrice.chotard@foss.st.com> wrote:
>
>
>
> On 10/27/25 14:35, Johan Hovold wrote:
> > On Tue, Sep 23, 2025 at 05:16:05PM +0200, Johan Hovold wrote:
> >> Make sure to drop the references taken to the I2C adapters during probe
> >> on probe failure (e.g. probe deferral) and on driver unbind.
> >>
> >> Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support")
> >> Cc: stable@vger.kernel.org   # 4.3
> >> Cc: Peter Griffin <peter.griffin@linaro.org>
> >> Signed-off-by: Johan Hovold <johan@kernel.org>
> >> ---
> >
> > Can this one be picked up for 6.19?
> >
> > Johan
>
>
> Hi Johan
>
> The removal of c8sectpfe driver has been initiated see https://lore.kernel.org/linux-media/c3a35ad6-c4f6-46ad-9b5b-1fe43385ecc5@foss.st.com/

Interesting, I hadn't seen that. I guess I should dispose of my b2120
board then!

Peter.

Re: [PATCH] media: c8sectpfe: fix probe device leaks

[Johan Hovold]

On Mon, Oct 27, 2025 at 03:28:57PM +0100, Patrice CHOTARD wrote:
> On 10/27/25 14:35, Johan Hovold wrote:
> > On Tue, Sep 23, 2025 at 05:16:05PM +0200, Johan Hovold wrote:
> >> Make sure to drop the references taken to the I2C adapters during probe
> >> on probe failure (e.g. probe deferral) and on driver unbind.
> >>
> >> Fixes: c5f5d0f99794 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support")
> >> Cc: stable@vger.kernel.org	# 4.3
> >> Cc: Peter Griffin <peter.griffin@linaro.org>
> >> Signed-off-by: Johan Hovold <johan@kernel.org>
> >> ---
> > 
> > Can this one be picked up for 6.19?

> The removal of c8sectpfe driver has been initiated see https://lore.kernel.org/linux-media/c3a35ad6-c4f6-46ad-9b5b-1fe43385ecc5@foss.st.com/

Ah, ok, thanks.

Johan