From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Ricardo Ribalda <ribalda@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] media: i2c: imx214: Rearrange control initialization
Date: Tue, 21 Oct 2025 12:18:01 +0300 [thread overview]
Message-ID: <aPdPyc6Lasmp3EzC@kekkonen.localdomain> (raw)
In-Reply-To: <20251020-imx214-smatch-v3-1-2c9999efc97c@chromium.org>
Hi Ricardo,
Thank you for the update.
On Mon, Oct 20, 2025 at 08:18:13PM +0000, Ricardo Ribalda wrote:
> Smatch is confused by the control initialization logic. It assumes that
> there can be a case where imx214->link_freq can be NULL and ctrls_init
> returns 0.
>
> Re-arrage the function to make smatch happy.
>
> This patch fixes this smatch error:
> drivers/media/i2c/imx214.c:1109 imx214_ctrls_init() error: we previously assumed 'imx214->link_freq' could be null (see line 1017)
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
next prev parent reply other threads:[~2025-10-21 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 20:18 [PATCH v3] media: i2c: imx214: Rearrange control initialization Ricardo Ribalda
2025-10-21 9:18 ` Sakari Ailus [this message]
2025-10-21 10:49 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPdPyc6Lasmp3EzC@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=ribalda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox