[PATCH] media: imx8-isi: Drop unused module alias

[PATCH] media: imx8-isi: Drop unused module alias

[Laurent Pinchart]

The driver has never supported anything but OF probing so drop the
unused platform module alias.

Suggested-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Johan, I've got the idea from similar patches you submitted for other
NXP media drivers, hence the Suggested-by tag. Please let me know if I
can keep it.

 drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
index c3d411ddf492..0f000582a1de 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
@@ -575,7 +575,6 @@ static struct platform_driver mxc_isi_driver = {
 };
 module_platform_driver(mxc_isi_driver);
 
-MODULE_ALIAS("ISI");
 MODULE_AUTHOR("Freescale Semiconductor, Inc.");
 MODULE_DESCRIPTION("IMX8 Image Sensing Interface driver");
 MODULE_LICENSE("GPL");

base-commit: 163917839c0eea3bdfe3620f27f617a55fd76302
-- 
Regards,

Laurent Pinchart

Re: [PATCH] media: imx8-isi: Drop unused module alias

[Frank Li]

On Mon, Nov 03, 2025 at 01:44:38AM +0200, Laurent Pinchart wrote:
> The driver has never supported anything but OF probing so drop the
> unused platform module alias.
>
> Suggested-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> Johan, I've got the idea from similar patches you submitted for other
> NXP media drivers, hence the Suggested-by tag. Please let me know if I
> can keep it.
>
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index c3d411ddf492..0f000582a1de 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -575,7 +575,6 @@ static struct platform_driver mxc_isi_driver = {
>  };
>  module_platform_driver(mxc_isi_driver);
>
> -MODULE_ALIAS("ISI");
>  MODULE_AUTHOR("Freescale Semiconductor, Inc.");
>  MODULE_DESCRIPTION("IMX8 Image Sensing Interface driver");
>  MODULE_LICENSE("GPL");
>
> base-commit: 163917839c0eea3bdfe3620f27f617a55fd76302
> --
> Regards,
>
> Laurent Pinchart
>

Re: [PATCH] media: imx8-isi: Drop unused module alias

[Johan Hovold]

Hi Laurent,

On Mon, Nov 03, 2025 at 01:44:38AM +0200, Laurent Pinchart wrote:
> The driver has never supported anything but OF probing so drop the
> unused platform module alias.

The commit message needs some more work since this isn't a platform
module alias (i.e. has a "platform:" prefix), and judging from a quick
look it seems like the driver did support platform probing before commit
605b57c4e888 ("media: nxp: imx8-isi: Drop partial support for i.MX8QM
and i.MX8QXP"), at least in theory.

It's probably fine to remove the "ISI" alias, but it should not affect
module autoloading.
 
> Suggested-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Johan, I've got the idea from similar patches you submitted for other
> NXP media drivers, hence the Suggested-by tag. Please let me know if I
> can keep it.

Sure, please do.

> -MODULE_ALIAS("ISI");

Johan

Re: [PATCH] media: imx8-isi: Drop unused module alias

[Laurent Pinchart]

On Tue, Nov 04, 2025 at 11:13:05AM +0100, Johan Hovold wrote:
> On Mon, Nov 03, 2025 at 01:44:38AM +0200, Laurent Pinchart wrote:
> > The driver has never supported anything but OF probing so drop the
> > unused platform module alias.
> 
> The commit message needs some more work since this isn't a platform
> module alias (i.e. has a "platform:" prefix),

Oops indeed.

> and judging from a quick
> look it seems like the driver did support platform probing before commit
> 605b57c4e888 ("media: nxp: imx8-isi: Drop partial support for i.MX8QM
> and i.MX8QXP"), at least in theory.

That has never been used upstream. It was code from the BSP that should
never have been imported in the first place, I missed removing it when I
rewrote the driver for upstreaming.

> It's probably fine to remove the "ISI" alias, but it should not affect
> module autoloading.

How about the following commit message ?


media: imx8-isi: Drop unneeded module alias

The imx8-isi driver has a module alias named "ISI". This is not
required, as there is no reason to load this module through an alias:
the device is probed through OF, and the module has never been named
"ISI". Drop the alias.

> > Suggested-by: Johan Hovold <johan@kernel.org>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Johan, I've got the idea from similar patches you submitted for other
> > NXP media drivers, hence the Suggested-by tag. Please let me know if I
> > can keep it.
> 
> Sure, please do.
> 
> > -MODULE_ALIAS("ISI");

-- 
Regards,

Laurent Pinchart

Re: [PATCH] media: imx8-isi: Drop unused module alias

[Johan Hovold]

On Tue, Nov 04, 2025 at 04:36:36PM +0200, Laurent Pinchart wrote:

> How about the following commit message ?
> 
> 
> media: imx8-isi: Drop unneeded module alias
> 
> The imx8-isi driver has a module alias named "ISI". This is not
> required, as there is no reason to load this module through an alias:
> the device is probed through OF, and the module has never been named
> "ISI". Drop the alias.

Looks good. Feel free to add my:

Reviewed-by: Johan Hovold <johan@kernel.org>