Re: [PATCH 1/4] media: dt-bindings: adi,adv7180: add VPP and CSI register maps

[Michael Tretter <m.tretter@pengutronix.de>]

Hi Dave,

On Tue, 11 Nov 2025 16:02:26 +0000, Dave Stevenson wrote:
> On Tue, 11 Nov 2025 at 14:50, Michael Tretter <m.tretter@pengutronix.de> wrote:
> >
> > The ADV7280 and ADV7280-M have up to three register maps for the VPP and
> > CSI. The address of these register maps may be programmed via registers
> > in the main register map.
> 
> AIUI all the ADV728x devices have at least 2 addresses, signified by
> the ADV7180_FLAG_MIPI_CSI2 and ADV7180_FLAG_I2P flags in their
> adv7180_chip_info structures.
> Is there a reason that you've restricted this to just the two chips?

I only have an ADV7280-M for testing. Thus, I restricted it to the chip
that I could test and the variant that's the same except for the CSI.

> 
> adv7281 - CSI
> adv7281-m - CSI
> adv7281-ma - CSI
> adv7282 - VPP
> adv7282-m - VPP and CSI
> 
> The adv7180 and adv7182 families are the only two which only have the
> single I2C address.

Are you suggesting to extend the binding to be able to specify the
addresses for the CSI and VPP for any of these chips?

Michael

> 
> Thanks.
>   Dave
> 
> > Allow to specify the addresses of the VPP and CSI in the device tree to
> > solve address conflicts on a board level.
> >
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > ---
> >  .../devicetree/bindings/media/i2c/adi,adv7180.yaml | 44 ++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/adi,adv7180.yaml b/Documentation/devicetree/bindings/media/i2c/adi,adv7180.yaml
> > index dee8ce7cb7ba..4bbdc812442b 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/adi,adv7180.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/adi,adv7180.yaml
> > @@ -138,6 +138,31 @@ allOf:
> >        required:
> >          - ports
> >
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - adi,adv7280
> > +              - adi,adv7280-m
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 1
> > +          maxItems: 3
> > +          description:
> > +            The ADV7280 and ADV7280-M have up to three register maps, which can be
> > +            accessed via the I2C port. The main register map, the VPP register map,
> > +            and the CSI register map. The main register map is mandatory. The other
> > +            register maps are optional and the default is used unless specified.
> > +
> > +        reg-names:
> > +          minItems: 1
> > +          items:
> > +            - const: main
> > +            - enum: [ csi, vpp ]
> > +            - enum: [ csi, vpp ]
> > +
> >  examples:
> >    - |
> >      i2c {
> > @@ -187,3 +212,22 @@ examples:
> >                      };
> >              };
> >      };
> > +
> > +  - |
> > +    i2c {
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            composite-in@20 {
> > +                    compatible = "adi,adv7280-m";
> > +                    reg = <0x20>, <0x42>, <0x44>;
> > +                    reg-names = "main", "vpp", "csi";
> > +
> > +                    port {
> > +                            adv7280_out: endpoint {
> > +                                    bus-width = <8>;
> > +                                    remote-endpoint = <&vin1ep>;
> > +                            };
> > +                    };
> > +            };
> > +    };
> >
> > --
> > 2.47.3
> >
> >
>