From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2202F7AA4 for ; Tue, 11 Nov 2025 17:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762882928; cv=none; b=q+W/uhJHVrpxgCNXbBWPr4fIXwwdN2yxtVn0UoOPZBx3U3U/BX6o+L6zdyj2bj5IzJvttkqTxektuYYKIWQeiGw7exeHaKImjvbjWPu0d1mz03oKkUaj+wjN9c2NqGg9g6VddE3szW1TkczlEAF2s/ODntx+Aoe1EgPVaD2LuP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762882928; c=relaxed/simple; bh=8C3OKfEDERrVEr8x+qfQYC+8B/6S0i1hQBcvICkv4rA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pz77nUKV/tVT4TsD5G27X8RcIpwrDflDOjcDjVmlt0BHB5qrdytyo9h7VCOBRqnYmVgPYKDXXze2NouwOXRGtnc7jb7wFipEmN4BE4LmEIWU/FGPc/ZKgyiG/LkqFOVUqOKu47OReK43FXR7uaUc7d68Pt4g+T2fMldRHx3AooU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vIsNO-00017y-0c; Tue, 11 Nov 2025 18:41:54 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vIsNN-008Ewj-2c; Tue, 11 Nov 2025 18:41:53 +0100 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vIsNN-00EYfh-2H; Tue, 11 Nov 2025 18:41:53 +0100 Date: Tue, 11 Nov 2025 18:41:53 +0100 From: Michael Tretter To: "Rob Herring (Arm)" Cc: Conor Dooley , Lars-Peter Clausen , devicetree@vger.kernel.org, Krzysztof Kozlowski , Mauro Carvalho Chehab , Niklas =?utf-8?Q?S=C3=B6derlund?= , linux-media@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 1/4] media: dt-bindings: adi,adv7180: add VPP and CSI register maps Message-ID: Mail-Followup-To: Michael Tretter , "Rob Herring (Arm)" , Conor Dooley , Lars-Peter Clausen , devicetree@vger.kernel.org, Krzysztof Kozlowski , Mauro Carvalho Chehab , Niklas =?utf-8?Q?S=C3=B6derlund?= , linux-media@vger.kernel.org, kernel@pengutronix.de References: <20251111-b4-adv7180-vpp-sub-device-v1-0-9877fe9f709b@pengutronix.de> <20251111-b4-adv7180-vpp-sub-device-v1-1-9877fe9f709b@pengutronix.de> <176287518543.2990003.9870195789780384180.robh@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <176287518543.2990003.9870195789780384180.robh@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org On Tue, 11 Nov 2025 09:33:05 -0600, Rob Herring (Arm) wrote: > On Tue, 11 Nov 2025 15:36:14 +0100, Michael Tretter wrote: > > The ADV7280 and ADV7280-M have up to three register maps for the VPP and > > CSI. The address of these register maps may be programmed via registers > > in the main register map. > > > > Allow to specify the addresses of the VPP and CSI in the device tree to > > solve address conflicts on a board level. > > > > Signed-off-by: Michael Tretter > > --- > > .../devicetree/bindings/media/i2c/adi,adv7180.yaml | 44 ++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/adi,adv7180.example.dtb: composite-in@20 (adi,adv7280-m): 'reg-names' does not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/media/i2c/adi,adv7180.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/adi,adv7180.example.dtb: composite-in@20 (adi,adv7280-m): reg: [[32], [66], [68]] is too long > from schema $id: http://devicetree.org/schemas/media/i2c/adi,adv7180.yaml I assumed that I could conditionally override the properties and use the existing definition as default. It seems that I have to explicitly set the default in the else path. I'll fix this in v2. > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251111-b4-adv7180-vpp-sub-device-v1-1-9877fe9f709b@pengutronix.de > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > >