public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Bryan O'Donoghue <bod@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: qcom: venus: flip the venus/iris switch
Date: Fri, 21 Nov 2025 14:22:46 +0100	[thread overview]
Message-ID: <aSBnpm1VduuPw9pW@linaro.org> (raw)
In-Reply-To: <20251119-venus-iris-flip-switch-v1-1-852369f66e36@oss.qualcomm.com>

On Wed, Nov 19, 2025 at 05:18:18PM +0200, Dmitry Baryshkov wrote:
> With the Iris and Venus driver having more or less feature parity for
> "HFI 6xx" platforms and with Iris gaining support for SC7280, flip the
> switch. Use Iris by default for SM8250 and SC7280, the platforms which
> are supported by both drivers, and use Venus only if Iris is not
> compiled at all. Use IS_ENABLED to strip out the code and data
> structures which are used by the disabled platforms.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

I think this will break the ChromeOS SC7280 platform, because the new
Iris driver does not (yet) support the non-PAS/TZ startup sequence.
Given that this is a dead (never released) platform, it probably does
not make sense blocking the switch from Venus to Iris, but it should be
made clear in the commit message at least. And perhaps the affected DTs
should be changed to disable Venus/Iris then.

It would be easy to add support for the non-PAS/TZ startup sequence in
the Iris driver. The changes exist already [1], they are just stuck on
the never ending discussion about how to model the additional
video-firmware IOMMU entry in the DT for newer platforms [2]. Perhaps
the existing legacy usage in SC7280 would be enough precedent to land
this patch as-is, although I don't have access to any SC7280-based board
for testing.

Thanks,
Stephan

[1]: https://git.codelinaro.org/stephan.gerhold/linux/-/commit/14db4bfae9279a0e69a0a9d2ccdd684658916431
[2]: https://lore.kernel.org/r/20250823155349.22344-2-krzysztof.kozlowski@linaro.org/

  parent reply	other threads:[~2025-11-21 13:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <10Ud2nacNpGLxEZdFk2VE6I40JkFU8f1S0lGFZayvkwiPgffhyV-gY3p_-AnMAAMckWDMVO__50mkrCB6NnyVg==@protonmail.internalid>
2025-11-19 15:18 ` [PATCH] media: qcom: venus: flip the venus/iris switch Dmitry Baryshkov
2025-11-20  9:22   ` Konrad Dybcio
2025-11-20  9:58   ` Bryan O'Donoghue
2025-11-20 10:00     ` Bryan O'Donoghue
2025-11-20 19:40     ` Jorge Ramirez
2025-11-21 12:18     ` Dmitry Baryshkov
2025-11-21 13:22   ` Stephan Gerhold [this message]
2025-11-21 14:14     ` Dmitry Baryshkov
2025-11-27 11:47   ` Vikash Garodia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSBnpm1VduuPw9pW@linaro.org \
    --to=stephan.gerhold@linaro.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=bod@kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox