Linux Media Controller development
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org,
	dave.stevenson@raspberrypi.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, mchehab@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v3 1/4] media: i2c: ov9282: Fix reset-gpio logical state
Date: Mon, 15 Dec 2025 11:40:03 +0200	[thread overview]
Message-ID: <aT_Xc6LR161QBRFp@kekkonen.localdomain> (raw)
In-Reply-To: <CAFEp6-1Tdmr5v0r+q0qeOG6qqA-hiBaF1iTEcmhBA0oTjLgbgg@mail.gmail.com>

Hi Loic,

On Mon, Dec 15, 2025 at 10:35:15AM +0100, Loic Poulain wrote:
> Hi Sakari,
> 
> On Mon, Nov 17, 2025 at 6:30 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > Hi Loic,
> >
> > On Fri, Nov 14, 2025 at 02:38:19PM +0100, Loic Poulain wrote:
> > > Ensure reset state is low in the power-on state and high in the
> > > power-off state (assert reset). Note that the polarity is abstracted
> > > by the GPIO subsystem, so the logic level reflects the intended reset
> > > behavior.
> >
> > That's an interesting approach to fix DTS gone systematically wrong.
> >
> > I was thinking of the drivers that have this issue, too, but I would have
> > introduced a new GPIO under a different name (many sensors use "enable",
> > too). Any thoughts?
> 
> Apologies for missing your point earlier. We can’t really name it
> enable, as it performs the opposite function and that would be
> confusing in the device tree description. A property like reset2 would
> be more accurate, but I suspect such a binding wouldn’t be acceptable
> from a device tree/bindings perspective.

Many sensor datasheets document a pin called "xshutdown" or alike. That's
not exactly "reset" or "enable" but it can be mapped to either and this can
be seen in the existing bindings. The polarity is effectively the opposite,
yes, but does that matter?

-- 
Regards,

Sakari Ailus

  reply	other threads:[~2025-12-15  9:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 13:38 [PATCH v3 0/4] Add QRB2210 RB1 vision mezzanine/kit support Loic Poulain
2025-11-14 13:38 ` [PATCH v3 1/4] media: i2c: ov9282: Fix reset-gpio logical state Loic Poulain
2025-11-17 17:30   ` Sakari Ailus
2025-12-03 10:00     ` Loic Poulain
2025-12-30 13:49       ` Krzysztof Kozlowski
2025-12-30 13:56       ` Krzysztof Kozlowski
2025-12-15  9:35     ` Loic Poulain
2025-12-15  9:40       ` Sakari Ailus [this message]
2025-12-15 10:19         ` Loic Poulain
2025-12-30 13:33           ` Laurent Pinchart
2025-12-30 13:54           ` Krzysztof Kozlowski
2025-12-30 15:03             ` Loic Poulain
2025-12-30 15:40               ` Laurent Pinchart
2025-12-30 15:41               ` Krzysztof Kozlowski
2026-01-06 19:53                 ` Loic Poulain
2025-11-14 13:38 ` [PATCH v3 2/4] arm64: dts: qcom: qcm2290: Add pin configuration for mclks Loic Poulain
2025-11-17 13:07   ` Konrad Dybcio
2025-11-14 13:38 ` [PATCH v3 3/4] arm64: dts: qcom: qrb2210-rb1: Add PM8008 node Loic Poulain
2025-11-14 13:38 ` [PATCH v3 4/4] arm64: dts: qcom: qrb2210-rb1: Add overlay for vision mezzanine Loic Poulain
2025-11-18  4:25   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aT_Xc6LR161QBRFp@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox