Linux Media Controller development
 help / color / mirror / Atom feed
From: Salvatore Bonaccorso <carnil@debian.org>
To: Ralf Jung <post@ralfj.de>, 1121718@bugs.debian.org
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Ricardo Ribalda" <ribalda@chromium.org>,
	linux-media@vger.kernel.org, regressions@lists.linux.dev,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>
Subject: Re: Bug#1121718: linux-image-6.17.8+deb14-amd64: Logitech C920 HD Pro Webcam shows flickering artifacts (sometimes)
Date: Fri, 2 Jan 2026 15:00:57 +0100	[thread overview]
Message-ID: <aVfPmZ8rUm3Vf7pT@eldamar.lan> (raw)
In-Reply-To: <0490a39a-28d9-4925-a162-5e4d498be257@ralfj.de>

Hi Ralf,

On Fri, Jan 02, 2026 at 02:24:20PM +0100, Ralf Jung wrote:
> Hi all,
> 
> I did a (lengthy) bisect session, and came out with this commit:

Thanks for doing so and for the time invested!

> 52fbe173baa4df9d14bd733f42ee6b9ceab8299b is the first bad commit
> commit 52fbe173baa4df9d14bd733f42ee6b9ceab8299b (HEAD)
> Author: Ricardo Ribalda <ribalda@chromium.org>
> Date:   Wed Dec 18 21:39:09 2024 +0000
> 
>     media: uvcvideo: Invert default value for nodrop module param
> 
>     The module param `nodrop` defines what to do with frames that contain an
>     error: drop them or sending them to userspace.
> 
>     The default in the rest of the media subsystem is to return buffers with
>     an error to userspace with V4L2_BUF_FLAG_ERROR set in v4l2_buffer.flags.
>     In UVC we drop buffers with errors by default.
> 
>     Change the default behaviour of uvcvideo to match the rest of the
>     drivers and maybe get rid of the module parameter in the future.
> 
>     Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>     Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>     Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>     Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>     Link: https://lore.kernel.org/r/20241218-uvc-deprecate-v2-2-ab814139e983@chromium.org
>     Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> 
>  drivers/media/usb/uvc/uvc_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I added Ricardo in Cc. Ricardo, see
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1121718 for context.
> 
> The bug does not always immediately manifest, so there is a small chance
> that for some of the commits that I marked "good", artifacts would have
> started appearing if I had waited a bit longer. But the commit seems
> reasonably plausible to be able to cause the kind of error I am seeing.
> 
> Given that this is about a module parameter, I assume I could test this by
> booting the latest kernel and setting the parameter back to its previous
> value... but I don't know enough about how the kernel works to actually do
> that.^^ Happy to try that if someone gives me some pointers.

You can create a modprobe.d file /etc/modprobe.d/uvcvideo.conf with

options uvcvideo nodrop=0

to pass 'nodrop=0' parameter when loading the uvcvideo module (then
unload and load the module).

But it already warns in dmesg when doing so with:

uvcvideo: [Deprecated]: nodrop parameter will be eventually removed.

Regards,
Salvatore

  reply	other threads:[~2026-01-02 14:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <aS8YBLEPwF0-NtJO@eldamar.lan>
     [not found] ` <176458169204.346596.13968096833088921213.reportbug@r-ethtop>
     [not found]   ` <ba9a132e-6296-451f-8351-4045c0b72d6c@ralfj.de>
     [not found]     ` <4rnbopkefvp6h3dwttj4h7cexehqtbuzzz4gatnebdnjzdy2li@bupytpnlk2xh>
     [not found]       ` <2ed13f74-8de3-4caf-8972-26dd5a31e9fc@ralfj.de>
2025-12-18  9:16         ` Bug#1121718: linux-image-6.17.8+deb14-amd64: Logitech C920 HD Pro Webcam shows flickering artifacts (sometimes) Uwe Kleine-König
2026-01-02 13:24           ` Ralf Jung
2026-01-02 14:00             ` Salvatore Bonaccorso [this message]
2026-01-02 16:28               ` Ralf Jung
2026-01-05 15:29                 ` Ricardo Ribalda
2026-01-05 15:43                   ` Ralf Jung
2026-01-05 18:00                   ` Laurent Pinchart
2026-01-05 18:32                     ` Ricardo Ribalda
2026-01-05 19:26                   ` Ralf Jung
2026-01-15  7:32                     ` Ricardo Ribalda
2026-01-20 13:46                       ` Ricardo Ribalda
2026-01-20 14:19                         ` Ralf Jung
2026-01-22 17:38                         ` Uwe Kleine-König
2026-01-22 17:54                           ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aVfPmZ8rUm3Vf7pT@eldamar.lan \
    --to=carnil@debian.org \
    --cc=1121718@bugs.debian.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=post@ralfj.de \
    --cc=regressions@lists.linux.dev \
    --cc=ribalda@chromium.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox