From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC9D335073 for ; Tue, 20 Jan 2026 03:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768881022; cv=none; b=F54ok9n6mJn9gL7ZJ2wmERwcy/FV8PCT+P1yBsQ4VGhH1ASuArrLJqR82DUTGILVOItELZavPP9fMc0vkiZINfI/+L6VvTdmk9Uh84IgCCxn1NbwWqV3EY85Ld+PmT0/JmVfXkeDSfbpW8PgH0+KgxXA0MTyir6ckcurG5EkMTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768881022; c=relaxed/simple; bh=YouqfwVWzYXpcikOlfu9sTS3gDOn1ZFujhD3ULTm95g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cER+Zpa/5E9KCJ/qgwVhxpfMISOXFc02R+1i9K9pK+HORyCGo9vUQZggydmna4WW5PjATSQJbdEGzx3TXGGrjxAjEXus9stnaES9cLbjr+rOznIAWF9wt6ZNDnWMeJil3TVE0V6WoTPVWg7rCw4As9YrRS1vPbiz4Cm+GxlfKIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZmqhouTb; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZmqhouTb" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-8c6a001e3bfso302333885a.1 for ; Mon, 19 Jan 2026 19:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768881020; x=1769485820; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J0ylyK0Iu22RJ/xkcdGlRObGYO0FeHTfl507VqBaAx4=; b=ZmqhouTbwST4ddALMVWqWYXrD6SOgQJIASZXcp1vBD6BF+Zo55rXjoSNVULPX/aRUW ur9RsyoFLFnJ6IMDWoqqNtsRoLyCqppfLbCN8/CR4nkAyXRqFlfP9OHMcxp9pm8FaKRI NYcwVFQ4jagrD5FgIYl/XzZKnbl3Wic0TpoI1ow0pjv9PA04fsQ8uuiePnWSlvfeGx+m r3apki+c9emFM70Q++iVoS2lyRHcMo4Wji42O7/5C3eyQ9mdC7TDLksftz4wFGgcqauk Ceczqnr/IlqyLmvKDN8Hj7H1NnXphNcPnq5zRf4rkbHVZOPqwDlgD7bhijGExMXJhnbd oqUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768881020; x=1769485820; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J0ylyK0Iu22RJ/xkcdGlRObGYO0FeHTfl507VqBaAx4=; b=HJ6uplTzFAYXKpRCrGv3pMBOiT2/41P3I/HQIc26wtnVCs2VihdZiyKHxlc9QIHmX2 8IyHkjAEm6XXPOQr4ODSc6SvnZkX7JvXWOF+cVo33J5L0U3WQr313XZ6eqUOAXyg0aFV gi7hOSIrgmuwwx0MA8oQBjIZP7dna4L1sRdLegdUQNvhGxPbemOwTqwqhujQkoA9IYlB PQFwxQW/iog+KvoXiaHIP538kr9bOdenAEXTFjjOhD0Q0UPII5ddu+/hPGoZkUwQgHiU 5ZIMflUkSmFxfXlcRd4KLhYJWI3GzOptOLHpTLzdtCBP16eyQQWhvuDotNAkzLxEnqaQ NyoQ== X-Forwarded-Encrypted: i=1; AJvYcCUrithli2+yzusFCcmR/Ny3J3o37uZB3upKuUB/Iw0JNOwMNNvy/a0MX4c5qLnfpNZk6eA+YW7VuXCu/w==@vger.kernel.org X-Gm-Message-State: AOJu0YyekvHFlrqd7B1KZEg0m+V4FQUFZ7zJSiac+kPttvsbT/eUoUK6 jP/gla2wBQ5VvIAcNAxBZ8Ax2P7syY8tsQjVgs2SzVy/3oXC4+nHWpbs X-Gm-Gg: AY/fxX5ta3CbY2d4fo+sDdyAHB8DiVfxi3ZYk6sAYqZmpiNjkE3yNl//vXwbAIENsts ef73QDLpfBC28a8RKnOUJVnz+BidT0ezxqTixxg4qXERt/G8rqqQ+xOLuebofZ7mCNr/aD1wzvv 3PSuxUST0c53piNtvR7klwiYugq7Nw9G1/byi3rrLLxaLzrti13/FDS4Ysl/+k8dMZI+zJLdiOx aZfDRNlpR7lphKNyu6AaPT/+XgZtBl9h1KBbJsxRXiZJHEQK873WTv9YYt/uqiTaapsCM2QaU0Z Eq0D/7HDYt0NDFvw6T///1ei8HXc+zJ3cPuDLiQz01207QAN9ULSOj677riedAwKpdXO1vm1p5S CofV+Zw+zvBF1F3dlrx9Q9OyWag9W6nsBT03Qu9pKT03fjgOULScWVlltJQuXcUoL5gBss+ASpt s+QrV4ylcqM+e5Fh6k6VH5vqaK X-Received: by 2002:a05:620a:3f97:b0:8b2:2607:83d5 with SMTP id af79cd13be357-8c6ccf2381fmr56720685a.75.1768881019642; Mon, 19 Jan 2026 19:50:19 -0800 (PST) Received: from localhost ([184.144.58.243]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6a7250a60sm936184085a.31.2026.01.19.19.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 19:50:19 -0800 (PST) Date: Mon, 19 Jan 2026 22:50:41 -0500 From: Richard Acayan To: Vladimir Zapolskiy Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Sakari Ailus , Tianshu Qiu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Robert Mader , Bryan O'Donoghue , David Heidelberg , phone-devel@vger.kernel.org Subject: Re: [PATCH v7 2/5] media: i2c: imx355: Support devicetree and power management Message-ID: References: <20260117040657.27043-1-mailingradian@gmail.com> <20260117040657.27043-3-mailingradian@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jan 17, 2026 at 02:03:02PM +0200, Vladimir Zapolskiy wrote: > On 1/17/26 06:06, Richard Acayan wrote: (snip) > > +static int imx355_power_on(struct device *dev) > > +{ > > + struct i2c_client *client = container_of(dev, struct i2c_client, dev); > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > + struct imx355 *imx355 = to_imx355(sd); > > + int ret; > > + > > + ret = clk_prepare_enable(imx355->clk); > > + if (ret) { > > + dev_err(dev, "failed to enable clocks: %d\n", ret); > > + return ret; > > + } > > + > > + ret = regulator_bulk_enable(ARRAY_SIZE(imx355_supplies), > > + imx355->supplies); > > + if (ret) { > > + dev_err(dev, "failed to enable regulators: %d\n", ret); > > + goto error_disable_clocks; > > + } > > + > > + gpiod_set_value_cansleep(imx355->reset_gpio, 1); > > + usleep_range(1000, 2000); > > The deassert above is not needed IMO, anyway. This assert is for clarity, otherwise it isn't obvious that the GPIO is asserted low when the function is called. It should stay.