From: Richard Acayan <mailingradian@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Robert Mader <robert.mader@collabora.com>,
Bryan O'Donoghue <bod@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
David Heidelberg <david@ixit.cz>,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v6 1/5] dt-bindings: media: i2c: Add Sony IMX355
Date: Thu, 8 Jan 2026 19:09:57 -0500 [thread overview]
Message-ID: <aWBHVUBhPa6iZ0ib@rdacayan> (raw)
In-Reply-To: <20260107-aspiring-unselfish-dogfish-963c1e@quoll>
On Wed, Jan 07, 2026 at 08:35:25AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Jan 06, 2026 at 11:30:40PM -0500, Richard Acayan wrote:
> > The IMX355 camera sensor is a camera sensor that can be found as the
> > front camera in some smartphones, such as the Pixel 3, Pixel 3 XL, Pixel
> > 3a, and Pixel 3a XL. It already has a driver, but needs support for
> > device tree. Document the IMX355 to support defining it in device tree.
> >
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
(snip)
> <form letter>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
>
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
>
> Read carefully last sentence above.
You left some comments after tagging your Reviewed-by, so I was unsure
if this changed the tag:
- https://lore.kernel.org/r/bc831622-8cbb-4bc6-b96c-9b87fb414725@kernel.org/
"Ah, here, this obviously was not ever [compile] tested."
- https://lore.kernel.org/r/fedeaca3-5549-4d57-8f13-f0ac58d1e4d0@kernel.org/
"why do you need data-lanes if they are fixed?"
About the data-lanes, they are unused by the driver and can be dropped
next revision.
next prev parent reply other threads:[~2026-01-09 0:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 4:30 [PATCH v6 0/5] media: i2c: IMX355 for the Pixel 3a Richard Acayan
2026-01-07 4:30 ` [PATCH v6 1/5] dt-bindings: media: i2c: Add Sony IMX355 Richard Acayan
2026-01-07 4:41 ` Vladimir Zapolskiy
2026-01-07 7:35 ` Krzysztof Kozlowski
2026-01-09 0:09 ` Richard Acayan [this message]
2026-01-07 4:30 ` [PATCH v6 2/5] media: i2c: imx355: Support devicetree and power management Richard Acayan
2026-01-07 4:55 ` Vladimir Zapolskiy
2026-01-07 7:34 ` Krzysztof Kozlowski
2026-01-08 3:28 ` Richard Acayan
2026-01-07 13:31 ` Bryan O'Donoghue
2026-01-07 18:49 ` Sakari Ailus
2026-01-08 4:15 ` Richard Acayan
2026-01-07 4:30 ` [PATCH v6 3/5] arm64: dts: qcom: sdm670: label the camss ports instead of endpoints Richard Acayan
2026-01-07 4:59 ` Vladimir Zapolskiy
2026-01-07 13:36 ` Bryan O'Donoghue
2026-01-07 4:30 ` [PATCH v6 4/5] arm64: dts: qcom: sdm670: add camera mclk pins Richard Acayan
2026-01-07 4:30 ` [PATCH v6 5/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera Richard Acayan
2026-01-07 5:05 ` Vladimir Zapolskiy
2026-01-07 13:37 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWBHVUBhPa6iZ0ib@rdacayan \
--to=mailingradian@gmail.com \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robert.mader@collabora.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox