public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Karthikey Kadati <karthikey3608@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
	sakari.ailus@linux.intel.com, andy@kernel.org,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	Unix Antigravity <unix.antigravity@test.com>
Subject: Re: [PATCH 4/4] staging: atomisp: Replace ia_css_region with v4l2_rect
Date: Mon, 12 Jan 2026 13:01:11 +0200	[thread overview]
Message-ID: <aWTUd6C_dchJ1Xcu@smile.fi.intel.com> (raw)
In-Reply-To: <20260112102518.19926-1-karthikey3608@gmail.com>

On Mon, Jan 12, 2026 at 03:55:18PM +0530, Karthikey Kadati wrote:
> Replace custom struct ia_css_region with standard struct v4l2_rect
> 
> to align with V4L2 API.

Your series is split (no common thread in email), please be sure you supplied
`git format-patch --thread ...` when created the series for sending.

...

>  #include <type_support.h>
>  
>  #include "ia_css_frac.h"
> +#include <linux/videodev2.h>

Linux headers should go first before other (there are some more generic headers
like dt-bindings, but it's not the case here).

>  #include "isp/kernels/aa/aa_2/ia_css_aa2_types.h"
>  #include "isp/kernels/anr/anr_1.0/ia_css_anr_types.h"

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-01-12 11:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 10:25 [PATCH 4/4] staging: atomisp: Replace ia_css_region with v4l2_rect Karthikey Kadati
2026-01-12 10:32 ` Dan Carpenter
2026-01-12 10:53 ` Sakari Ailus
2026-01-12 11:01 ` Andy Shevchenko [this message]
2026-01-12 11:07 ` Andy Shevchenko
2026-01-14 18:14   ` Karthikey Kadati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWTUd6C_dchJ1Xcu@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=karthikey3608@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=unix.antigravity@test.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox