From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: dan.scally@ideasonboard.com, jacopo.mondi@ideasonboard.com,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: mali-c55: core: Remove redundant dev_err()
Date: Thu, 15 Jan 2026 15:17:45 +0100 [thread overview]
Message-ID: <aWj20s8j5Y6_Qdz3@zed> (raw)
In-Reply-To: <20260115023516.4142364-1-nichen@iscas.ac.cn>
Hi Chen
On Thu, Jan 15, 2026 at 10:35:16AM +0800, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
>
> Remove the redundant dev_err() call to clean up the error path.
>
Indeed
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Thanks
j
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/media/platform/arm/mali-c55/mali-c55-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> index 43b834459ccf..ab8f7f6f3be1 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> @@ -868,7 +868,6 @@ static int mali_c55_probe(struct platform_device *pdev)
> mali_c55->irqnum = platform_get_irq(pdev, 0);
> if (mali_c55->irqnum < 0) {
> ret = mali_c55->irqnum;
> - dev_err(dev, "failed to get interrupt\n");
> goto err_deinit_media_frameworks;
> }
>
> --
> 2.25.1
>
prev parent reply other threads:[~2026-01-15 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 2:35 [PATCH] media: mali-c55: core: Remove redundant dev_err() Chen Ni
2026-01-15 7:38 ` Dan Scally
2026-01-15 14:17 ` Jacopo Mondi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWj20s8j5Y6_Qdz3@zed \
--to=jacopo.mondi@ideasonboard.com \
--cc=dan.scally@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox