From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E31D33A6E2 for ; Fri, 13 Feb 2026 14:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770993769; cv=none; b=oyNFC1az2wu3yEJAhrccHKHHX4hR/ww2eYq9TnAxDW+SFooOhLAlkM1uA7X0PCSxN+Lebe7cvQk2KHk0jUK2q3glBl7bjB3FwhBzuf0DrHPHJWjX1gEmsPjcFXn7Y9dLE/he0WQx4ns+mTl5sBkENBhzn2/QeEjy4fAyBmiNM2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770993769; c=relaxed/simple; bh=5LZEiyblmE5cjTTaA/tSxotTzlumfsspN658jeKcIks=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RQECXKxb2Aky/wWwFI8UtIS85xTz+p9TZ7704K6hJdk5RQpfe55YO3XJPGCNncwCpvVVpQ5TfYQ6m5Jje6Ay6xAAkdupvxoBFMIwQhJchSq+1HEFwD8sSdjILiX6FR2ODHcWyoo2DHx1aYdYytysvTvvkmZZBY2WejW3iIV4KK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=vHrUV/4Z; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vHrUV/4Z" Received: from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 77695348; Fri, 13 Feb 2026 15:41:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770993716; bh=5LZEiyblmE5cjTTaA/tSxotTzlumfsspN658jeKcIks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vHrUV/4ZjlYCRgRFR7NXLIljrUYHD6gdNtAl5QKgqeKpgqbCdFfOWd5caAQ354xPo WyvJKvRD4TsySezMlq9s14EZQ187uDnKOC7ucH/Z9gVJndGfFab8h0AetTD+5+Yzlc euWeBQu2cUP1QRsCWpM7xRLPOCws8CqeYq1vcS5s= Date: Fri, 13 Feb 2026 15:42:41 +0100 From: Jacopo Mondi To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Alexander Shiyan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" Subject: Re: [PATCH v2 01/14] media: imx219: Rename "PIXEL_ARRAY" as "CROP" Message-ID: References: <20260211090920.1851141-1-sakari.ailus@linux.intel.com> <20260211090920.1851141-2-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260211090920.1851141-2-sakari.ailus@linux.intel.com> Hi Sakari How is this related to the metadata seris ? :) Shouldn't we aim to fast track that series instead of adding more things as requisites ? On Wed, Feb 11, 2026 at 11:09:07AM +0200, Sakari Ailus wrote: > The imx219 driver uses macros for denoting different aspects of the pixel > array. The values used for IMX219_PIXEL_ARRAY_* macros imply a crop > configuration however, not the size of the pixel array. Reflect this in > the naming, too. 3280x2464 is the active pixel array area, according to the datasheet. I guess one can claim is the default crop (it is in facts used as DEFAULT_CROP and CROP_BOUNDS rectangle), so: Acked-by: Jacopo Mondi > > Signed-off-by: Sakari Ailus > --- > drivers/media/i2c/imx219.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index fee63bc106d9..54622c406a03 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -142,10 +142,10 @@ > /* IMX219 native and active pixel array size. */ > #define IMX219_NATIVE_WIDTH 3296U > #define IMX219_NATIVE_HEIGHT 2480U > -#define IMX219_PIXEL_ARRAY_LEFT 8U > -#define IMX219_PIXEL_ARRAY_TOP 8U > -#define IMX219_PIXEL_ARRAY_WIDTH 3280U > -#define IMX219_PIXEL_ARRAY_HEIGHT 2464U > +#define IMX219_CROP_LEFT 8U > +#define IMX219_CROP_TOP 8U > +#define IMX219_CROP_WIDTH 3280U > +#define IMX219_CROP_HEIGHT 2464U > > /* Mode : resolution and related config&values */ > struct imx219_mode { > @@ -675,13 +675,13 @@ static int imx219_set_framefmt(struct imx219 *imx219, > bpp = imx219_get_format_bpp(format); > > cci_write(imx219->regmap, IMX219_REG_X_ADD_STA_A, > - crop->left - IMX219_PIXEL_ARRAY_LEFT, &ret); > + crop->left - IMX219_CROP_LEFT, &ret); > cci_write(imx219->regmap, IMX219_REG_X_ADD_END_A, > - crop->left - IMX219_PIXEL_ARRAY_LEFT + crop->width - 1, &ret); > + crop->left - IMX219_CROP_LEFT + crop->width - 1, &ret); > cci_write(imx219->regmap, IMX219_REG_Y_ADD_STA_A, > - crop->top - IMX219_PIXEL_ARRAY_TOP, &ret); > + crop->top - IMX219_CROP_TOP, &ret); > cci_write(imx219->regmap, IMX219_REG_Y_ADD_END_A, > - crop->top - IMX219_PIXEL_ARRAY_TOP + crop->height - 1, &ret); > + crop->top - IMX219_CROP_TOP + crop->height - 1, &ret); > > imx219_get_binning(state, &bin_h, &bin_v); > cci_write(imx219->regmap, IMX219_REG_BINNING_MODE_H, bin_h, &ret); > @@ -867,8 +867,8 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, > * Use binning to maximize the crop rectangle size, and centre it in the > * sensor. > */ > - bin_h = min(IMX219_PIXEL_ARRAY_WIDTH / format->width, 2U); > - bin_v = min(IMX219_PIXEL_ARRAY_HEIGHT / format->height, 2U); > + bin_h = min(IMX219_CROP_WIDTH / format->width, 2U); > + bin_v = min(IMX219_CROP_HEIGHT / format->height, 2U); > > /* Ensure bin_h and bin_v are same to avoid 1:2 or 2:1 stretching */ > binning = min(bin_h, bin_v); > @@ -967,10 +967,10 @@ static int imx219_get_selection(struct v4l2_subdev *sd, > > case V4L2_SEL_TGT_CROP_DEFAULT: > case V4L2_SEL_TGT_CROP_BOUNDS: > - sel->r.top = IMX219_PIXEL_ARRAY_TOP; > - sel->r.left = IMX219_PIXEL_ARRAY_LEFT; > - sel->r.width = IMX219_PIXEL_ARRAY_WIDTH; > - sel->r.height = IMX219_PIXEL_ARRAY_HEIGHT; > + sel->r.top = IMX219_CROP_TOP; > + sel->r.left = IMX219_CROP_LEFT; > + sel->r.width = IMX219_CROP_WIDTH; > + sel->r.height = IMX219_CROP_HEIGHT; > > return 0; > } > -- > 2.47.3 > >