From: Dan Carpenter <dan.carpenter@linaro.org>
To: Michael Riesch <michael.riesch@collabora.com>
Cc: linux-media@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [bug report] media: synopsys: add driver for the designware mipi csi-2 receiver
Date: Fri, 6 Feb 2026 16:39:01 +0300 [thread overview]
Message-ID: <aYXu9Sf4aEl8c3ym@stanley.mountain> (raw)
In-Reply-To: <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>
[ Smatch checking is paused while we raise funding. #SadFace
https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
Hello Michael Riesch,
Commit 355a11004066 ("media: synopsys: add driver for the designware
mipi csi-2 receiver") from Jan 20, 2026 (linux-next), leads to the
following Smatch static checker warning:
drivers/media/platform/synopsys/dw-mipi-csi2rx.c:307 dw_mipi_csi2rx_enum_mbus_code()
warn: array off by one? 'csi2->formats[code->index]'
drivers/media/platform/synopsys/dw-mipi-csi2rx.c
286 static int
287 dw_mipi_csi2rx_enum_mbus_code(struct v4l2_subdev *sd,
288 struct v4l2_subdev_state *sd_state,
289 struct v4l2_subdev_mbus_code_enum *code)
290 {
291 struct dw_mipi_csi2rx_device *csi2 = to_csi2(sd);
292
293 switch (code->pad) {
294 case DW_MIPI_CSI2RX_PAD_SRC:
295 if (code->index)
296 return -EINVAL;
297
298 code->code =
299 v4l2_subdev_state_get_format(sd_state,
300 DW_MIPI_CSI2RX_PAD_SINK)->code;
301
302 return 0;
303 case DW_MIPI_CSI2RX_PAD_SINK:
304 if (code->index > csi2->formats_num)
This should be >=.
305 return -EINVAL;
306
--> 307 code->code = csi2->formats[code->index].code;
308 return 0;
309 default:
310 return -EINVAL;
311 }
312 }
regards,
dan carpenter
next parent reply other threads:[~2026-02-06 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>
2026-02-06 13:39 ` Dan Carpenter [this message]
2026-02-06 13:39 ` [bug report] media: rockchip: rkcif: add support for rk3568 vicap mipi capture Dan Carpenter
2026-02-16 13:33 ` Michael Riesch
2026-02-06 13:39 ` [bug report] media: iris: gen1: Destroy internal buffers after FW releases Dan Carpenter
2026-02-06 13:40 ` [bug report] media: chips-media: wave5: Fix Null reference while testing fluster Dan Carpenter
2026-02-11 7:59 ` Nas Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYXu9Sf4aEl8c3ym@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=michael.riesch@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox