From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Matt Wardle <matt@mattwardle.net>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: Fix brace style issues in binary.c
Date: Mon, 9 Feb 2026 10:24:59 +0200 [thread overview]
Message-ID: <aYmZ20RmdmJY0Pp_@smile.fi.intel.com> (raw)
In-Reply-To: <20260209044854.83299-1-matt@mattwardle.net>
On Mon, Feb 09, 2026 at 04:49:22AM +0000, Matt Wardle wrote:
> Fix checkpatch.pl errors and warnings regarding braces on incorrect
> lines and braces not required for single statement blocks
Missing period.
Note, if you are going to do this file-by-file, it won't scale. So, collect
(sub)folder and fix all files in that one for the same issue. Then repeat
the same for other (sub)folders. Make it a series of the patches.
...
> int
> -ia_css_binary_init_infos(void) {
> +ia_css_binary_init_infos(void)
Side note: This can be one line now.
...
> int
> -ia_css_binary_uninit(void) {
> +ia_css_binary_uninit(void)
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-09 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 4:49 [PATCH] media: atomisp: Fix brace style issues in binary.c Matt Wardle
2026-02-09 8:24 ` Andy Shevchenko [this message]
2026-02-09 11:22 ` Matt Wardle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYmZ20RmdmJY0Pp_@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matt@mattwardle.net \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox