Re: [PATCH v2 08/14] media: mc: Don't care about unsettable flags in MEDIA_IOC_LINK_SETUP

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Mirela,

On Mon, Feb 16, 2026 at 03:55:15PM +0200, Mirela Rabulea wrote:
> Hi Sakari,
> 
> On 2/11/26 11:09, Sakari Ailus wrote:
> > The implementation of MEDIA_IOC_LINK_SETUP currently requires that all
> > flags that are set by the driver are correctly set as the driver expect.
> expect->expects
> > This poses a problem for adding new flags as programs could not work with
> > links that have unknown flags even when the use of these flags wouldn't
> > affect the program.
> > 
> > Ignore the non-settable link flags.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> >   drivers/media/mc/mc-entity.c | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> > index b29b519237d6..cf72bfb8885c 100644
> > --- a/drivers/media/mc/mc-entity.c
> > +++ b/drivers/media/mc/mc-entity.c
> > @@ -1378,7 +1378,7 @@ static int __media_entity_setup_link_notify(struct media_link *link, u32 flags)
> > 
> >   int __media_entity_setup_link(struct media_link *link, u32 flags)
> >   {
> > -       const u32 mask = MEDIA_LNK_FL_ENABLED;
> > +       const u32 settable_flags = MEDIA_LNK_FL_ENABLED;
> >          struct media_device *mdev;
> >          struct media_pad *source, *sink;
> >          int ret = -EBUSY;
> > @@ -1386,10 +1386,6 @@ int __media_entity_setup_link(struct media_link *link, u32 flags)
> >          if (link == NULL)
> >                  return -EINVAL;
> > 
> > -       /* The non-modifiable link flags must not be modified. */
> > -       if ((link->flags & ~mask) != (flags & ~mask))
> > -               return -EINVAL;
> > -
> >          if (link->flags & MEDIA_LNK_FL_IMMUTABLE)
> >                  return link->flags == flags ? 0 : -EINVAL;
> > 
> > @@ -1403,6 +1399,10 @@ int __media_entity_setup_link(struct media_link *link, u32 flags)
> >              (media_pad_is_streaming(source) || media_pad_is_streaming(sink)))
> >                  return -EBUSY;
> > 
> > +       /* Only allow changing user-settable flags. */
> > +       flags &= settable_flags;
> > +       flags |= link->flags & ~settable_flags;
> > +
> 
> The immutable check now compares before filtering, previously this was after
> the filtering. Is this change intentional?

Indeed; this patch looked different earlier and I forgot to move the
condition back to where it was. I'll do that for v3.

-- 
Regards,

Sakari Ailus