From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Shawn Tu <shawnx.tu@intel.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 6/6] media: i2c: og01a1b: Add support of 8-bit media bus format
Date: Mon, 9 Mar 2026 13:55:51 +0200 [thread overview]
Message-ID: <aa61R5mcCE1zu125@kekkonen.localdomain> (raw)
In-Reply-To: <20260226133739.4050870-7-vladimir.zapolskiy@linaro.org>
Hi Vladimir,
Thanks for the set.
On Thu, Feb 26, 2026 at 03:37:39PM +0200, Vladimir Zapolskiy wrote:
> @@ -627,6 +632,14 @@ static int og01a1b_enable_streams(struct v4l2_subdev *sd,
> return ret;
> }
>
> + ret = cci_write(og01a1b->regmap, CCI_REG8(0x3662),
> + (og01a1b->code == MEDIA_BUS_FMT_Y10_1X10 ? 0x4 : 0x6),
Does this configuration have a human-readable name? It'd be nice to use
that instead of a plain numerical value.
> + NULL);
> + if (ret) {
> + dev_err(og01a1b->dev, "failed to set output format: %d\n", ret);
> + return ret;
> + }
> +
> ret = __v4l2_ctrl_handler_setup(og01a1b->sd.ctrl_handler);
> if (ret)
> goto error;
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2026-03-09 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 13:37 [PATCH 0/6] media: i2c: og01a1b: Updates to the driver and 8-bit mode support Vladimir Zapolskiy
2026-02-26 13:37 ` [PATCH 1/6] media: i2c: og01a1b: Fix V4L2 subdevice data initialization on probe Vladimir Zapolskiy
2026-02-26 13:37 ` [PATCH 2/6] media: i2c: og01a1b: Switch from .s_stream to .enable_streams/.disable_streams Vladimir Zapolskiy
2026-02-26 13:37 ` [PATCH 3/6] media: i2c: og01a1b: Change I2C interface controls to V4L2 CCI Vladimir Zapolskiy
2026-02-26 13:37 ` [PATCH 4/6] media: i2c: og01a1b: Replace .open with .init_state internal ops Vladimir Zapolskiy
2026-02-26 13:37 ` [PATCH 5/6] media: i2c: og01a1b: Use generic v4l2_subdev_get_fmt() to get format Vladimir Zapolskiy
2026-02-26 13:37 ` [PATCH 6/6] media: i2c: og01a1b: Add support of 8-bit media bus format Vladimir Zapolskiy
2026-03-09 11:55 ` Sakari Ailus [this message]
2026-03-09 21:56 ` Vladimir Zapolskiy
2026-03-10 8:03 ` Sakari Ailus
2026-03-10 11:08 ` Sakari Ailus
2026-03-10 13:12 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa61R5mcCE1zu125@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=shawnx.tu@intel.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox