From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9D4C433FE for ; Thu, 10 Feb 2022 03:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232070AbiBJDGM (ORCPT ); Wed, 9 Feb 2022 22:06:12 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbiBJDGL (ORCPT ); Wed, 9 Feb 2022 22:06:11 -0500 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDBAE2B272; Wed, 9 Feb 2022 19:06:11 -0800 (PST) X-UUID: 61480397f04c4a228c946c16b270b18b-20220210 X-UUID: 61480397f04c4a228c946c16b270b18b-20220210 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 734615389; Thu, 10 Feb 2022 11:06:09 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 10 Feb 2022 11:06:07 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 10 Feb 2022 11:06:06 +0800 Message-ID: Subject: Re: [PATCH v2, 1/7] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for lat soc From: "yunfei.dong@mediatek.com" To: Rob Herring CC: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , AngeloGioacchino Del Regno , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Matthias Brugger , Tomasz Figa , George Sun , Xiaoyong Lu , Hsin-Yi Wang , "Fritz Koenig" , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , , , , , , , Date: Thu, 10 Feb 2022 11:06:06 +0800 In-Reply-To: References: <20220128035440.24533-1-yunfei.dong@mediatek.com> <20220128035440.24533-2-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Rob, Thanks for your suggestion. On Wed, 2022-02-09 at 14:37 -0600, Rob Herring wrote: > On Fri, Jan 28, 2022 at 11:54:34AM +0800, Yunfei Dong wrote: > > Adds decoder dt-bindings for compatible "mediatek,mtk-vcodec-lat- > > soc". > > What's lat soc? How does this relate to what's already there in this > binding. > lat soc is another hardware, is related with some vdec larb ports. Won't be used to decode, but must to write it in dtsi, or hardware can't work well. Need to enable clock/power/iommus, no interrupt. > The subject space is limited, avoid saying the same thing twice > (dt-bindings). > Best Regards, Yunfei Dong > > > > Signed-off-by: Yunfei Dong > > --- > > .../media/mediatek,vcodec-subdev-decoder.yaml | 49 > > +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev- > > decoder.yaml > > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev- > > decoder.yaml > > index 6415c9f29130..a3c892338ac0 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > subdev-decoder.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > subdev-decoder.yaml > > @@ -189,6 +189,55 @@ patternProperties: > > > > additionalProperties: false > > > > + '^vcodec-lat-soc@[0-9a-f]+$': > > + type: object > > + > > + properties: > > + compatible: > > + const: mediatek,mtk-vcodec-lat-soc > > + > > + reg: > > + maxItems: 1 > > + > > + iommus: > > + minItems: 1 > > + maxItems: 32 > > + description: | > > + List of the hardware port in respective IOMMU block for > > current Socs. > > + Refer to bindings/iommu/mediatek,iommu.yaml. > > + > > + clocks: > > + maxItems: 5 > > + > > + clock-names: > > + items: > > + - const: sel > > + - const: soc-vdec > > + - const: soc-lat > > + - const: vdec > > + - const: top > > + > > + assigned-clocks: > > + maxItems: 1 > > + > > + assigned-clock-parents: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > + required: > > + - compatible > > + - reg > > + - iommus > > + - clocks > > + - clock-names > > + - assigned-clocks > > + - assigned-clock-parents > > + - power-domains > > + > > + additionalProperties: false > > + > > required: > > - compatible > > - reg > > -- > > 2.25.1 > > > >