From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, andy@kernel.org, hansg@kernel.org,
mchehab@kernel.org, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev,
Soufiane Dani <soufianeda@tutanota.com>
Subject: Re: [PATCH 1/1] staging: media: atomisp: Disallow all private IOCTLSs but S_PARAMETERS
Date: Fri, 27 Feb 2026 11:31:29 +0200 [thread overview]
Message-ID: <aaFkcS1fMVLxGB87@smile.fi.intel.com> (raw)
In-Reply-To: <20260227092327.3654603-1-sakari.ailus@linux.intel.com>
On Fri, Feb 27, 2026 at 11:23:27AM +0200, Sakari Ailus wrote:
> Disallow all private IOCTLs except ATOMISP_IOC_S_PARAMETERS. These aren't
> quite as safe as one could assume of IOCTL handlers; disable them for now.
> Instead of removing the code, simply check the IOCTL matches with
> S_PARAMETERS and bail out otherwise, in order to ease backporting.
> In particular, ATOMISP_IOC_S_ISP_FPN_TABLE is disabled by this patch.
Why not removing the code?
It's still and will be in the Git index, it won't disappear.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-27 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 9:23 [PATCH 1/1] staging: media: atomisp: Disallow all private IOCTLSs but S_PARAMETERS Sakari Ailus
2026-02-27 9:31 ` Andy Shevchenko [this message]
2026-02-27 10:54 ` Sakari Ailus
2026-02-28 10:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaFkcS1fMVLxGB87@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=soufianeda@tutanota.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox