From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED77025DD1E; Fri, 6 Mar 2026 08:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787387; cv=none; b=Tu5q8BFY+5ntkCmJ3GuQI7Nd+RjiGFdUSTbSfkJ7wQr/anJSqamDN/9UuM6VSFuFKoMXof5KfildMGjwlSZNQ/poNo0DR+bTd+JkqfNKZA6nVPRjBNeNLDuiQ/Hb/d/311mJVQCC4uijxV1Mdh79QQGvnR+fjEJFL/1NXmvdkg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787387; c=relaxed/simple; bh=CqmetSlsO1ht2MuKvR3HS08d+xLH108esXwQ5bx1YmU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FFCSzSAIlSbEA64HtNplvtYVdzoBMDELFcOxONrwWQLB4NIo/7KhJRmMVjflRPorE1Od9GC0UaUHQdP9h50LVhX3GAYWJR9Qv/smGVvWTAQY3V/jiKV8zXStDX736hNyjZIduDf4wC5dNPLC3QenH97GlQa+8vWPQQQ4WVimx5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=tuHwJ0vO; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tuHwJ0vO" Received: from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it [93.46.82.201]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 91BD8591; Fri, 6 Mar 2026 09:55:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1772787310; bh=CqmetSlsO1ht2MuKvR3HS08d+xLH108esXwQ5bx1YmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tuHwJ0vObLMzqpzKtFUFoD+w0yeJ583Qa013AZijXK15FBq+6DFhUwBzKD9XpZ+0U duB8vS9mgaMAdGuTV7vJAIsKrUMWoOf0PiqI5P8qvTLSYowodAxHtuFwZFz99FG9lG tyhWvSkr5oY4cdKYzm4sJ23Z/4pN0XA9DNzECIB4= Date: Fri, 6 Mar 2026 09:56:11 +0100 From: Jacopo Mondi To: Alper Ak Cc: Markus Elfring , linux-media@vger.kernel.org, Daniel Scally , Jacopo Mondi , LKML , Hans Verkuil , Mauro Carvalho Chehab , Nayden Kanchev Subject: Re: [PATCH] media: malic55: Fix possible ERR_PTR deference in enable_streams Message-ID: References: <20260207091822.601255-1-alperyasinak1@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Alper, On Fri, Mar 06, 2026 at 09:31:22AM +0300, Alper Ak wrote: > Hello everyone, look like this patch hasn't been applied. Did I miss > something I needed to do to get it applied? If there is anything I > need to do, please let me know. No, I think it's good. The only think I see is my comment As per the other patch for the CRU, it might be nice to attribute credit to the static analysis tool you have used. which makes me think there was a discussion on another patch about the tool. If you wish to resend to add credit, you're welcome to do so. Otherwise, patches are collected in the media tree before the current -rc6 (usually) so seat back and relax it might still take a while. > > > Markus Elfring , 14 Şub 2026 Cmt, 17:37 > tarihinde şunu yazdı: > > > > … > > > pointer or an ERR_PTR() on failure … > > > > error pointer > > > > > > > Add proper error checking with IS_ERR() before dereferencing the > > > pointer. Also set isp->remote_src to NULL on error to maintain > > > consistency with other error paths in the function. > > … > > > > * See also once more: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19#n34 > > > > * Were any source code analysis tools involved here? > > > > * Would a summary phrase like “Prevent error pointer dereference > > in mali_c55_isp_enable_streams()” be more appropriate? > > > > > > Regards, > > Markus > >