[PATCH] staging: media: av7110: remove print_time() dead code

[PATCH] staging: media: av7110: remove print_time() dead code

[Tomasz Unger]

The DEBUG_TIMING macro is commented out and can never be defined,
making the print_time() function body always empty. Remove the
commented-out macro, the unused function definition and all its
call sites as they serve no purpose.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Checked with scripts/checkpatch.pl - no errors, no warnings.
Compiled and verified by loading the module in QEMU.
---
 drivers/staging/media/av7110/av7110.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 607992100baf..9f4ed1e24b17 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -314,17 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len,
 	}
 }
 
-//#define DEBUG_TIMING
-static inline void print_time(char *s)
-{
-#ifdef DEBUG_TIMING
-	struct timespec64 ts;
-
-	ktime_get_real_ts64(&ts);
-	pr_info("%s(): %ptSp\n", s, &ts);
-#endif
-}
-
 #define DEBI_READ 0
 #define DEBI_WRITE 1
 static inline void start_debi_dma(struct av7110 *av7110, int dir,
@@ -353,7 +342,6 @@ static void debiirq(struct tasklet_struct *t)
 	int handle = (type >> 8) & 0x1f;
 	unsigned int xfer = 0;
 
-	print_time("debi");
 	dprintk(4, "type 0x%04x\n", type);
 
 	if (type == -1) {
@@ -473,7 +461,6 @@ static void gpioirq(struct tasklet_struct *t)
 	txbuf = irdebi(av7110, DEBINOSWAP, TX_BUFF, 0, 2);
 	len = (av7110->debilen + 3) & ~3;
 
-	print_time("gpio");
 	dprintk(8, "GPIO0 irq 0x%04x %d\n", av7110->debitype, av7110->debilen);
 
 	switch (av7110->debitype & 0xff) {
@@ -2785,7 +2772,6 @@ static void av7110_irq(struct saa7146_dev *dev, u32 *isr)
 {
 	struct av7110 *av7110 = dev->ext_priv;
 
-	//print_time("av7110_irq");
 
 	/* Note: Don't try to handle the DEBI error irq (MASK_18), in
 	 * intel mode the timeout is asserted all the time...

---
base-commit: 82e1c68ac206efe42854296c462aa83f541ea22c
change-id: 20260320-av7110-remove-print-time-87331ecc1f66

Best regards,
-- 
Tomasz Unger <tomasz.unger@yahoo.pl>

Re: [PATCH] staging: media: av7110: remove print_time() dead code

[Dan Carpenter]

On Fri, Mar 20, 2026 at 09:46:15AM +0100, Tomasz Unger wrote:
> The DEBUG_TIMING macro is commented out and can never be defined,
> making the print_time() function body always empty. Remove the
> commented-out macro, the unused function definition and all its
> call sites as they serve no purpose.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Checked with scripts/checkpatch.pl - no errors, no warnings.
> Compiled and verified by loading the module in QEMU.
> ---
>  drivers/staging/media/av7110/av7110.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..9f4ed1e24b17 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -314,17 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len,
>  	}
>  }
>  
> -//#define DEBUG_TIMING
> -static inline void print_time(char *s)
> -{
> -#ifdef DEBUG_TIMING
> -	struct timespec64 ts;
> -
> -	ktime_get_real_ts64(&ts);
> -	pr_info("%s(): %ptSp\n", s, &ts);
> -#endif
> -}
> -
>  #define DEBI_READ 0
>  #define DEBI_WRITE 1
>  static inline void start_debi_dma(struct av7110 *av7110, int dir,
> @@ -353,7 +342,6 @@ static void debiirq(struct tasklet_struct *t)
>  	int handle = (type >> 8) & 0x1f;
>  	unsigned int xfer = 0;
>  
> -	print_time("debi");
>  	dprintk(4, "type 0x%04x\n", type);
>  
>  	if (type == -1) {
> @@ -473,7 +461,6 @@ static void gpioirq(struct tasklet_struct *t)
>  	txbuf = irdebi(av7110, DEBINOSWAP, TX_BUFF, 0, 2);
>  	len = (av7110->debilen + 3) & ~3;
>  
> -	print_time("gpio");
>  	dprintk(8, "GPIO0 irq 0x%04x %d\n", av7110->debitype, av7110->debilen);
>  
>  	switch (av7110->debitype & 0xff) {
> @@ -2785,7 +2772,6 @@ static void av7110_irq(struct saa7146_dev *dev, u32 *isr)
>  {
>  	struct av7110 *av7110 = dev->ext_priv;
>  
> -	//print_time("av7110_irq");
>  
>  	/* Note: Don't try to handle the DEBI error irq (MASK_18), in

Delete the extra blank line as well.

regards,
dan carpenter