* [PATCH] staging: media: av7110: remove print_time() dead code [not found] <20260320-av7110-remove-print-time-v1-1-05402287078a.ref@yahoo.pl> @ 2026-03-20 8:46 ` Tomasz Unger 2026-03-20 9:37 ` Dan Carpenter 0 siblings, 1 reply; 2+ messages in thread From: Tomasz Unger @ 2026-03-20 8:46 UTC (permalink / raw) To: Mauro Carvalho Chehab, Greg Kroah-Hartman Cc: linux-media, linux-staging, linux-kernel, Tomasz Unger The DEBUG_TIMING macro is commented out and can never be defined, making the print_time() function body always empty. Remove the commented-out macro, the unused function definition and all its call sites as they serve no purpose. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> --- Checked with scripts/checkpatch.pl - no errors, no warnings. Compiled and verified by loading the module in QEMU. --- drivers/staging/media/av7110/av7110.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c index 607992100baf..9f4ed1e24b17 100644 --- a/drivers/staging/media/av7110/av7110.c +++ b/drivers/staging/media/av7110/av7110.c @@ -314,17 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len, } } -//#define DEBUG_TIMING -static inline void print_time(char *s) -{ -#ifdef DEBUG_TIMING - struct timespec64 ts; - - ktime_get_real_ts64(&ts); - pr_info("%s(): %ptSp\n", s, &ts); -#endif -} - #define DEBI_READ 0 #define DEBI_WRITE 1 static inline void start_debi_dma(struct av7110 *av7110, int dir, @@ -353,7 +342,6 @@ static void debiirq(struct tasklet_struct *t) int handle = (type >> 8) & 0x1f; unsigned int xfer = 0; - print_time("debi"); dprintk(4, "type 0x%04x\n", type); if (type == -1) { @@ -473,7 +461,6 @@ static void gpioirq(struct tasklet_struct *t) txbuf = irdebi(av7110, DEBINOSWAP, TX_BUFF, 0, 2); len = (av7110->debilen + 3) & ~3; - print_time("gpio"); dprintk(8, "GPIO0 irq 0x%04x %d\n", av7110->debitype, av7110->debilen); switch (av7110->debitype & 0xff) { @@ -2785,7 +2772,6 @@ static void av7110_irq(struct saa7146_dev *dev, u32 *isr) { struct av7110 *av7110 = dev->ext_priv; - //print_time("av7110_irq"); /* Note: Don't try to handle the DEBI error irq (MASK_18), in * intel mode the timeout is asserted all the time... --- base-commit: 82e1c68ac206efe42854296c462aa83f541ea22c change-id: 20260320-av7110-remove-print-time-87331ecc1f66 Best regards, -- Tomasz Unger <tomasz.unger@yahoo.pl> ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: av7110: remove print_time() dead code 2026-03-20 8:46 ` [PATCH] staging: media: av7110: remove print_time() dead code Tomasz Unger @ 2026-03-20 9:37 ` Dan Carpenter 0 siblings, 0 replies; 2+ messages in thread From: Dan Carpenter @ 2026-03-20 9:37 UTC (permalink / raw) To: Tomasz Unger Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media, linux-staging, linux-kernel On Fri, Mar 20, 2026 at 09:46:15AM +0100, Tomasz Unger wrote: > The DEBUG_TIMING macro is commented out and can never be defined, > making the print_time() function body always empty. Remove the > commented-out macro, the unused function definition and all its > call sites as they serve no purpose. > > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- > Checked with scripts/checkpatch.pl - no errors, no warnings. > Compiled and verified by loading the module in QEMU. > --- > drivers/staging/media/av7110/av7110.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c > index 607992100baf..9f4ed1e24b17 100644 > --- a/drivers/staging/media/av7110/av7110.c > +++ b/drivers/staging/media/av7110/av7110.c > @@ -314,17 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len, > } > } > > -//#define DEBUG_TIMING > -static inline void print_time(char *s) > -{ > -#ifdef DEBUG_TIMING > - struct timespec64 ts; > - > - ktime_get_real_ts64(&ts); > - pr_info("%s(): %ptSp\n", s, &ts); > -#endif > -} > - > #define DEBI_READ 0 > #define DEBI_WRITE 1 > static inline void start_debi_dma(struct av7110 *av7110, int dir, > @@ -353,7 +342,6 @@ static void debiirq(struct tasklet_struct *t) > int handle = (type >> 8) & 0x1f; > unsigned int xfer = 0; > > - print_time("debi"); > dprintk(4, "type 0x%04x\n", type); > > if (type == -1) { > @@ -473,7 +461,6 @@ static void gpioirq(struct tasklet_struct *t) > txbuf = irdebi(av7110, DEBINOSWAP, TX_BUFF, 0, 2); > len = (av7110->debilen + 3) & ~3; > > - print_time("gpio"); > dprintk(8, "GPIO0 irq 0x%04x %d\n", av7110->debitype, av7110->debilen); > > switch (av7110->debitype & 0xff) { > @@ -2785,7 +2772,6 @@ static void av7110_irq(struct saa7146_dev *dev, u32 *isr) > { > struct av7110 *av7110 = dev->ext_priv; > > - //print_time("av7110_irq"); > > /* Note: Don't try to handle the DEBI error irq (MASK_18), in Delete the extra blank line as well. regards, dan carpenter ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-20 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260320-av7110-remove-print-time-v1-1-05402287078a.ref@yahoo.pl>
2026-03-20 8:46 ` [PATCH] staging: media: av7110: remove print_time() dead code Tomasz Unger
2026-03-20 9:37 ` Dan Carpenter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox