Re: [PATCH] platform/x86: int3472: Add GPIO type 0x02 (strobe) mapping

[Marco Nenciarini <mnencia@kcore.it>]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

Hi Andy,

First, apologies for the triple submission. It was a sending error
on my side (mutt submitted three separate copies), not three patch
versions. Please disregard the duplicates.

Regarding your feedback:

> Link tag, Closes tags, Cc placement

Noted, thank you for the clear guidance. I will apply these if I
send an updated version.

> get_maintainer.pl

Thank you for the pointer and for sharing your ge2maintainer.sh
script.

> strobe / privacy-led mapping

Hans pointed out that GPIO type 0x02 is actually for an IR flood
LED, not a privacy LED. After digging into the ACPI tables on my
machine, I confirmed he is correct. The GPIO belongs to an INT3472
controlling an empty IR sensor slot, not the active OV08F4 camera.
I have replied to Hans with the full analysis. The mapping in this
patch is semantically wrong, so it may not be needed at all, or it
would need the refactoring Hans suggested.

Thanks,
Marco

-- 
Marco Nenciarini - mnencia@kcore.it
7C23 B804 3E65 D298 0A21  B6E2 589F 03F0 1BA5 5038

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]