Re: [PATCH v7 05/15] gpu: host1x: convert MIPI to use operation function pointers

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]

On Thu, Mar 19, 2026 at 11:20:58AM +0900, Mikko Perttunen wrote:
> On Tuesday, March 17, 2026 10:07 PM Hans Verkuil wrote:
> > Hi Svyatoslav, Mikko, Thierry,
> > 
> > On 03/03/2026 09:42, Svyatoslav Ryhel wrote:
> > > Convert existing MIPI code to use operation function pointers, a necessary
> > > step for supporting Tegra20/Tegra30 SoCs. All common MIPI configuration
> > > that is SoC-independent remains in mipi.c, while all SoC-specific code is
> > > moved to tegra114-mipi.c (The naming matches the first SoC generation with
> > > a dedicated calibration block). Shared structures and function calls are
> > > placed into tegra-mipi-cal.h.
> > > 
> > > Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # tegra20, parallel
> > > camera Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > Acked-by: Mikko Perttunen <mperttunen@nvidia.com>
> > 
> > I would like to merge this series, but in the v5 series there was a
> > discussion about this host1x split:
> > 
> > https://lore.kernel.org/linux-media/CAPVz0n0fkMYV-O4xWTBELd6HtKR83wrs+DS1wTV
> > DOXdWuAK2OA@mail.gmail.com/
> > 
> > Mikko Acked this patch, but Thierry objected. However, I saw no further
> > updates on this, and I do agree with Svyatoslav that this patch makes
> > sense.
> > 
> > If there are no objections, then I plan to merge series this on Monday for
> > v7.1.
> 
> Please do, I believe we ended up resolving that discussion offline.

I don't think we did. I never got any replies to my original objections,
only some vague complaints about the current state of the code being a
maintainer's hell (curious that I never felt it to be that way, being
the actual maintainer of this code...).

Anyway, the damage is done, you guys get to deal with it now.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]