Re: [PATCH] platform/x86: int3472: Add GPIO type 0x02 (strobe) mapping

[Marco Nenciarini <mnencia@kcore.it>]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

Hi Hans,

Thank you for the detailed review.

You are absolutely right. I dug into the ACPI tables on my Dell Pro
Max 16 Premium (Arrow Lake-H) and found the following:

There are 19 INT3472 template devices in the DSDT, but only one is
active: DSC0 (\_SB_.PC00.DSC0, uid=0, status=15). DSC0 has two GPIO
entries:
  - GPIO entry 1: type 0x12 (HANDSHAKE), pin 1
  - GPIO entry 2: type 0x02 (STROBE), pin 48

DSC0 is paired with LNK0 (sensor slot 0), which has no active sensor
on this machine. The OV08F4 color sensor is on LNK1, which on Arrow
Lake depends on CVSS (INTC10E0, Intel CVS Device), not on any INT3472.

Three sensors are defined in ACPI:
  - OVTI08F4 on LNK1 (status=15, active) — the front-facing color camera
  - OVTI13B1 on LNK2 (status=0, disabled)
  - OVTI01AS on LNK3 (status=0, disabled) — likely the IR sensor

So the GPIO type 0x02 warning comes from an INT3472 that controls a
non-existent IR sensor slot. The warning is harmless noise in this
case and the patch is not actually needed for the OV08F4 to work.

That said, the patch (or your suggested refactoring with a proper
"ir_flood_led" name) would still clean up the warning for any system
where an IR sensor slot's INT3472 is enabled without the sensor
being present. Would it be worth pursuing as a cleanup, or is it
better to just leave the warning as-is since it correctly flags an
unconfigured GPIO?

Thanks,
Marco

-- 
Marco Nenciarini - mnencia@kcore.it
7C23 B804 3E65 D298 0A21  B6E2 589F 03F0 1BA5 5038

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]