From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, andy@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: atomisp: fix block comment style in refcount.c
Date: Tue, 10 Mar 2026 13:43:13 +0200 [thread overview]
Message-ID: <abAD0ZvWiTUDizs8@ashevche-desk.local> (raw)
In-Reply-To: <20260309215516.6091-1-rayfraytech@gmail.com>
On Mon, Mar 09, 2026 at 10:55:16PM +0100, Oskar Ray-Frayssinet wrote:
> Fix block comment formatting to comply with kernel coding style:
> - Add leading '*' on continuation lines
> - Move trailing '*/' to a separate line
> - Remove unnecessary braces around single statement block
Are they the only ones to fix in the entire driver?
...
> /* TODO: enable for other memory aswell
> - now only for ia_css_ptr */
> + * now only for ia_css_ptr
> + */
/*
* Please, fix them in a better
* way as depicted by this comment.
*/
...
> /* ia_css_debug_dtrace(IA_CSS_DBG_TRACE,
> - "ia_css_refcount_uninit: freeing (%x)\n",
> - entry->data);*/
> + * "ia_css_refcount_uninit: freeing (%x)\n",
> + * entry->data);
> + */
No, instead use #if 0 ... #endif. Or even better if you find any existing
compile-time definition for that (instead of 0).
...
> /* ia_css_debug_dtrace(IA_CSS_DBEUG_TRACE,
> - "ia_css_refcount_decrement: freeing\n");*/
> + * "ia_css_refcount_decrement: freeing\n");
> + */
Ditto.
...
> - if (entry->count != 0) {
> + if (entry->count != 0)
> IA_CSS_WARNING("Ref count for entry %x is not zero!", entry->id);
> - }
Make this to be a separate patch, and find more occurrences of a such.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-10 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 21:55 [PATCH] staging: atomisp: fix block comment style in refcount.c Oskar Ray-Frayssinet
2026-03-10 11:43 ` Andy Shevchenko [this message]
2026-03-10 20:35 ` [PATCH v2] staging: media: " Oskar Ray-Frayssinet
2026-03-10 22:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abAD0ZvWiTUDizs8@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=rayfraytech@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox