From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3625635F616; Fri, 13 Mar 2026 11:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773401827; cv=none; b=UcAjgVdVSgd+YiJKS/RtGxrXqXzYlKpDeLFP835hp2QiTGp9W6bOB6yoJpq3vZNcbs/3KzhhSuck5/HDM0n53RZnKb1ovXbUMLNpFe18OujsJ4/Je+8uqjB+vXgmWl57hUmyZabyTVOW6WXBy+AnJnWAkxJII3zdoYxk+Y4Ubi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773401827; c=relaxed/simple; bh=v+t/YcPItl9BmhKZbd4tDOxUNwcnc1sJiB9izierkCk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZTYHqZpvSaoCCpaLuL5TXIBv4sJHMuWlRC+lihAmFY0bfU8PmEvFPH2qyXy3kR3+eqPF++AzGq4h/fndmlu9C+/I/Xs7VQy/FBpva49cEe06XOjF0bFt56kvJ80Xg2gNR6vS8VM2Y4k5zAwn703du5M0VukQWfQGlMEIrNNGa/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=KL4PJ99q; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KL4PJ99q" Received: from ideasonboard.com (mob-5-90-29-175.net.vodafone.it [5.90.29.175]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BFFEF52; Fri, 13 Mar 2026 12:35:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773401755; bh=v+t/YcPItl9BmhKZbd4tDOxUNwcnc1sJiB9izierkCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KL4PJ99qvyaJODrY+7+VkEkI9V16qA9u0cOROtX3a/yjoX4GcaSVx5pYBTU+bg3Ui eUy0+mjj6jelyhDy5QTYYhgsPDt7KHFzENmnM9IVCktMMuItGWkSk9whL0TdYJTToP P2cC4A+7ObzIu00OeJ3REEmSpcvQwZZYGLcDy7/c= Date: Fri, 13 Mar 2026 12:37:00 +0100 From: Jacopo Mondi To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Jacopo Mondi , Anthony McGivern , Vincenzo Frascino , Nayden Kanchev , Konstantin Babin , Daniel Scally , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4/6] media: mali-c55: Fix Iridix bypass macros Message-ID: References: <20260313-mali-c55-fixes-v7-0-v1-0-21805b2b516b@ideasonboard.com> <20260313-mali-c55-fixes-v7-0-v1-4-21805b2b516b@ideasonboard.com> <36f2247c-cfd5-46b4-a16d-1afc3a6504d8@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <36f2247c-cfd5-46b4-a16d-1afc3a6504d8@ideasonboard.com> On Fri, Mar 13, 2026 at 12:15:10PM +0100, Barnabás Pőcze wrote: > 2026. 03. 13. 11:49 keltezéssel, Jacopo Mondi írta: > > From: Daniel Scally > > > > The Mali C55 Iridix block has a digital gain function and tone mapping > > function, whose enablement is controlled by two different bits > > in the BYPASS_3 register. > > > > Unfortunately, the "Gain" and "Tonemap" bypass bit definitions are the > > wrong way around. Swap them so that the ISP is now operated with the > > "Iridix Gain" block enabled and default configured at a x1.0 gain and > > with the "Iridix Tonemap" disabled, as it was originally intended. > > As far as I can see the current upstream driver does not bypass either of them, > so swapping them will have no direct effect. You're right, I swapped the patch order and in this version I sent out this comes before the actual iridix bypass > > > > > > Cc: stable@vger.kernel.org > > Fixes: 8ec187829a4c ("media: mali-c55: Fix Iridix bypass macros") > > Where is this commit? I cannot seem to find it. Clearly, this doesn't make sense. I generated the fixes tag pointing it to this patch. I'll fix, thanks. > > > Reviewed-by: Barnabás Pőcze > > > > Signed-off-by: Daniel Scally > > Signed-off-by: Jacopo Mondi > > --- > > drivers/media/platform/arm/mali-c55/mali-c55-registers.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-registers.h b/drivers/media/platform/arm/mali-c55/mali-c55-registers.h > > index f5a148add1c8..f098effde7b4 100644 > > --- a/drivers/media/platform/arm/mali-c55/mali-c55-registers.h > > +++ b/drivers/media/platform/arm/mali-c55/mali-c55-registers.h > > @@ -128,8 +128,8 @@ enum mali_c55_interrupts { > > #define MALI_C55_REG_BYPASS_3_SENSOR_OFFSET_PRE_SH BIT(1) > > #define MALI_C55_REG_BYPASS_3_MESH_SHADING BIT(3) > > #define MALI_C55_REG_BYPASS_3_WHITE_BALANCE BIT(4) > > -#define MALI_C55_REG_BYPASS_3_IRIDIX BIT(5) > > -#define MALI_C55_REG_BYPASS_3_IRIDIX_GAIN BIT(6) > > +#define MALI_C55_REG_BYPASS_3_IRIDIX_GAIN BIT(5) > > +#define MALI_C55_REG_BYPASS_3_IRIDIX BIT(6) > > #define MALI_C55_REG_BYPASS_4 0x18ec0 > > #define MALI_C55_REG_BYPASS_4_DEMOSAIC_RGB BIT(1) > > #define MALI_C55_REG_BYPASS_4_PF_CORRECTION BIT(3) > > >