From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/media/av7110: update FIXME comment for signal strength
Date: Mon, 16 Mar 2026 11:08:23 +0300 [thread overview]
Message-ID: <abe6d4x5wFwtcCiA@stanley.mountain> (raw)
In-Reply-To: <20260312-staging-cleanup-v1-1-fdb9f8367e3f@yahoo.pl>
On Thu, Mar 12, 2026 at 07:21:17PM +0100, Tomasz Unger wrote:
> Update the FIXME comment to provide more detail about the future
> implementation for computing the signal strength based on the tuner RSSI.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> drivers/staging/media/av7110/av7110_v4l.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/av7110/av7110_v4l.c b/drivers/staging/media/av7110/av7110_v4l.c
> index 200a7a29ea31..a64761979609 100644
> --- a/drivers/staging/media/av7110/av7110_v4l.c
> +++ b/drivers/staging/media/av7110/av7110_v4l.c
> @@ -310,7 +310,7 @@ static int vidioc_g_tuner(struct file *file, void *fh, struct v4l2_tuner *t)
> V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
> t->rangelow = 772; /* 48.25 MHZ / 62.5 kHz = 772, see fi1216mk2-specs, page 2 */
> t->rangehigh = 13684; /* 855.25 MHz / 62.5 kHz = 13684 */
> - /* FIXME: add the real signal strength here */
> + /* TODO: compute based on tuner RSSI */
This seems reasonable and also pointless. Is this AI?
regards,
dan carpenter
> t->signal = 0xffff;
> t->afc = 0;
>
>
> ---
prev parent reply other threads:[~2026-03-16 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260312-staging-cleanup-v1-1-fdb9f8367e3f.ref@yahoo.pl>
2026-03-12 18:21 ` [PATCH] staging/media/av7110: update FIXME comment for signal strength Tomasz Unger
2026-03-16 8:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe6d4x5wFwtcCiA@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox