* [PATCH] staging/media/av7110: update FIXME comment for signal strength
[not found] <20260312-staging-cleanup-v1-1-fdb9f8367e3f.ref@yahoo.pl>
@ 2026-03-12 18:21 ` Tomasz Unger
2026-03-16 8:08 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Unger @ 2026-03-12 18:21 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel, Tomasz Unger
Update the FIXME comment to provide more detail about the future
implementation for computing the signal strength based on the tuner RSSI.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/av7110/av7110_v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/av7110/av7110_v4l.c b/drivers/staging/media/av7110/av7110_v4l.c
index 200a7a29ea31..a64761979609 100644
--- a/drivers/staging/media/av7110/av7110_v4l.c
+++ b/drivers/staging/media/av7110/av7110_v4l.c
@@ -310,7 +310,7 @@ static int vidioc_g_tuner(struct file *file, void *fh, struct v4l2_tuner *t)
V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
t->rangelow = 772; /* 48.25 MHZ / 62.5 kHz = 772, see fi1216mk2-specs, page 2 */
t->rangehigh = 13684; /* 855.25 MHz / 62.5 kHz = 13684 */
- /* FIXME: add the real signal strength here */
+ /* TODO: compute based on tuner RSSI */
t->signal = 0xffff;
t->afc = 0;
---
base-commit: 80234b5ab240f52fa45d201e899e207b9265ef91
change-id: 20260312-staging-cleanup-de930b5bfead
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging/media/av7110: update FIXME comment for signal strength
2026-03-12 18:21 ` [PATCH] staging/media/av7110: update FIXME comment for signal strength Tomasz Unger
@ 2026-03-16 8:08 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-03-16 8:08 UTC (permalink / raw)
To: Tomasz Unger
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel
On Thu, Mar 12, 2026 at 07:21:17PM +0100, Tomasz Unger wrote:
> Update the FIXME comment to provide more detail about the future
> implementation for computing the signal strength based on the tuner RSSI.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> drivers/staging/media/av7110/av7110_v4l.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/av7110/av7110_v4l.c b/drivers/staging/media/av7110/av7110_v4l.c
> index 200a7a29ea31..a64761979609 100644
> --- a/drivers/staging/media/av7110/av7110_v4l.c
> +++ b/drivers/staging/media/av7110/av7110_v4l.c
> @@ -310,7 +310,7 @@ static int vidioc_g_tuner(struct file *file, void *fh, struct v4l2_tuner *t)
> V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
> t->rangelow = 772; /* 48.25 MHZ / 62.5 kHz = 772, see fi1216mk2-specs, page 2 */
> t->rangehigh = 13684; /* 855.25 MHz / 62.5 kHz = 13684 */
> - /* FIXME: add the real signal strength here */
> + /* TODO: compute based on tuner RSSI */
This seems reasonable and also pointless. Is this AI?
regards,
dan carpenter
> t->signal = 0xffff;
> t->afc = 0;
>
>
> ---
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-16 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260312-staging-cleanup-v1-1-fdb9f8367e3f.ref@yahoo.pl>
2026-03-12 18:21 ` [PATCH] staging/media/av7110: update FIXME comment for signal strength Tomasz Unger
2026-03-16 8:08 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox