[PATCH v2] media: staging: av7110: update FIXME comment for signal strength

[PATCH v2] media: staging: av7110: update FIXME comment for signal strength

[Tomasz Unger]

Update the FIXME comment to provide more detail about the future
implementation for computing the signal strength based on the tuner RSSI.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Changes in v2:
- Fix subject prefix to use 'media: staging: av7110:' format
- Link to v1: https://lore.kernel.org/r/20260312-staging-cleanup-v1-1-fdb9f8367e3f@yahoo.pl
---
 drivers/staging/media/av7110/av7110_v4l.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/av7110/av7110_v4l.c b/drivers/staging/media/av7110/av7110_v4l.c
index 200a7a29ea31..a64761979609 100644
--- a/drivers/staging/media/av7110/av7110_v4l.c
+++ b/drivers/staging/media/av7110/av7110_v4l.c
@@ -310,7 +310,7 @@ static int vidioc_g_tuner(struct file *file, void *fh, struct v4l2_tuner *t)
 		V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
 	t->rangelow = 772;	/* 48.25 MHZ / 62.5 kHz = 772, see fi1216mk2-specs, page 2 */
 	t->rangehigh = 13684;	/* 855.25 MHz / 62.5 kHz = 13684 */
-	/* FIXME: add the real signal strength here */
+	/* TODO: compute based on tuner RSSI */
 	t->signal = 0xffff;
 	t->afc = 0;
 

---
base-commit: 80234b5ab240f52fa45d201e899e207b9265ef91
change-id: 20260312-staging-cleanup-de930b5bfead

Best regards,
-- 
Tomasz Unger <tomasz.unger@yahoo.pl>

Re: [PATCH v2] media: staging: av7110: update FIXME comment for signal strength

[Dan Carpenter]

On Fri, Mar 13, 2026 at 08:39:07AM +0100, Tomasz Unger wrote:
> Update the FIXME comment to provide more detail about the future
> implementation for computing the signal strength based on the tuner RSSI.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Changes in v2:
> - Fix subject prefix to use 'media: staging: av7110:' format
> - Link to v1: https://lore.kernel.org/r/20260312-staging-cleanup-v1-1-fdb9f8367e3f@yahoo.pl

This seems like a pointless change.

Somehow I guess someone told people to grep for FIXMEs and try fix them
but this patch doesn't fix anything.  It just re-words the FIXME and
changes it to a TODO.

regards,
dan carpener