From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: av7110: replace C++ comments with C style comments
Date: Mon, 16 Mar 2026 11:22:12 +0300 [thread overview]
Message-ID: <abe9tJq8F_lx6767@stanley.mountain> (raw)
In-Reply-To: <20260313-av7110-cpp-comments-v1-1-10c3b3f67fc3@yahoo.pl>
On Fri, Mar 13, 2026 at 05:18:48PM +0100, Tomasz Unger wrote:
> @@ -314,7 +314,7 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len,
> }
> }
>
> -//#define DEBUG_TIMING
> +/* #define DEBUG_TIMING */
Delete?
> static inline void print_time(char *s)
> {
> #ifdef DEBUG_TIMING
> @@ -762,7 +762,7 @@ static int StartHWFilter(struct dvb_demux_filter *dvbdmxfilter)
> u16 buf[20];
> int ret, i;
> u16 handle;
> -// u16 mode = 0x0320;
> + /* u16 mode = 0x0320; */
Delete this. You're going to need to send multiple patches:
1: Delete dead code.
2: Update comments.
regards,
dan carpenter
prev parent reply other threads:[~2026-03-16 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260313-av7110-cpp-comments-v1-1-10c3b3f67fc3.ref@yahoo.pl>
2026-03-13 16:18 ` [PATCH] staging: media: av7110: replace C++ comments with C style comments Tomasz Unger
2026-03-16 8:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe9tJq8F_lx6767@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox